search

bsmg / ModAssistant

Simple Beat Saber Mod Installer
MIT License
2.49k stars 419 forks source link

Dialog box to find beat saber directory won't let me select folder. #442

Open debterr opened 2 years ago

debterr commented 2 years ago

Steps to reproduce

  1. Not have Oculus folder on C Drive
  2. Open Mod Assistant.exe
  3. Get Could not detect error - "Could not detect your Beat Saber install folder. Please select it manually."
  4. Hit "OK" button
  5. Directory Finder pops up, however the save type won't let you select a folder instead its looking for a file with the extension .this.directory (See Picture)

with the correct directory selected its only giving me the option to open the folder rather then letting me select the folder.

image

Assistant commented 2 years ago

You need to be inside the directory, not have it selected. The reason it looks for a file called select.this.directory and not a folder is because for whatever reason the framework only lets you use the the old style of chooser dialog for that, which is harder to use and navigate, so MA uses a hack with the save file dialog instead. Y5zXQ

sync1211 commented 2 years ago

There is a NuGet package which provides an alternative dialog for folder selection (CommonOpenFileDialog).

Alternatively there is also an open-source implementation of these Vista-Dialogs.

However I am not sure if it makes sense to add a new dependency just because of one dialog.

Assistant commented 2 years ago

Thanks for the suggestions, however MA can't use dependencies that would build into a separate file.

debterr commented 2 years ago

Okay I got it to work by going inside the folder and hitting save.. just seems to go against what the prompts ask you to do, might be nice to put something in there that informs you to not just select the folder, but to go inside the folder?

Appreciate your help on this however! Also maybe something that can be done, if we put MA in the hyperbolic-magnetism-beat-saber folder can it look to see if its in that folder first? Might be easier then dealing with the dialogue, since the user already has to figure out where their folder is?