SpellCraft - Aspects of Valor (USA) (Proto) skips the main menu when pressing B

[Screwtapello]

At the title-screen of SpellCraft - Aspects of Valor, pressing Start or the D-Pad will bring up a menu letting you choose "New Game" or "Continue". However, if you press B, it will bring up the menu and automatically select "New Game" without giving you a chance to choose.

It's possible this is just the way the game is supposed to work, but this behaviour was specifically mentioned as a bug in #86. The other behaviour mentioned in that bug (B summoning and automatically dismissing the "Get Password" dialog) is still fixed, and I vaguely recall this behaviour was fixed too, but it's certainly not fixed now.

We should:

• double check what happens on real hardware
• double check what happens on commit 4f7a269
• if there was a regression, find where it was introduced

[Screwtapello]

On the current nightly (83e76c87eb0b45b3265893337960218b5a9ca94e), using my 360 pad under Linux:

• any other button brings up the main menu and does not auto-repeat, no matter how long I hold it down
• if I try very hard to just momentarily flick the B button, it brings up the main menu and does not activate "New Game"
• if I press the B button firmly, it brings up the main menu and activates "New Game"

Commit 4f7a269 behaves the same way.

Jonas Quinn says (on Discord) "If you just tap B on real hardware, it'll not automatically skip to new game. If you hold it, it will." He also says "on Linux it works like real hardware, on Windows holding B does not skip to new game automatically, that's really strange (tested bsnes and higan)."

I'm gonna call this Not A Bug.