search

bsnes-emu / bsnes

bsnes is a Super Nintendo (SNES) emulator focused on performance, features, and ease of use.
Other
1.67k stars 154 forks source link

Auto joypad cleanup #174

Closed Screwtapello closed 3 years ago

Screwtapello commented 3 years ago

Jonas Quinn refactored higan's auto-joypad polling in https://github.com/higan-emu/higan/commit/e422ddc7293b10aae8a1935d4c7f96aeb8445430, then Asura re-implemented those changes for bsnes in 39c37ec. A bug was found in bsnes, fixed in 4f7a269, and Jonas Quinn ported the bsnes version of the code back to higan in https://github.com/higan-emu/higan/commit/9a625c545ca89b094d5c1da40bbfa5d07156a4aa.

In the process of that (back?) port, Jonas discovered that the autoJoypadActive and autoJoypadLatch variables were no longer actually being used in bsnes. Also, Jonas' original patch taught higan what happens when auto-joypad polling is disabled while active, and that detail had not made it across to bsnes before.

With these changes, bsnes and higan should once again be equally accurate emulators.

near-san commented 3 years ago

Looks great, thank you for all your hard work Screwtape!! And Jonas too!