bsnes-emu / bsnes

bsnes is a Super Nintendo (SNES) emulator focused on performance, features, and ease of use.
Other
1.64k stars 154 forks source link

Bahamut Lagoon audio sync issue #244

Open jjohnson652 opened 2 years ago

jjohnson652 commented 2 years ago

Confirmed on bsnes 115; not sure if it affects Higan.

In Bahamut Lagoon patched with Near's English translation and with mostly default settings (Run-Ahead disabled, OpenGL 3.2 video, WASAPI 48k 0 latency audio, Audio synchronized), I've noticed a single video/audio sync issue in nearly 2 full playthroughs.

When the player summons Leviathan, the summoning effect uses a combination of Mode 7 and sprites (I think). At the end, it is clear that the large polygon is supposed to appear on-screen at the same time as a sound effect, but the polygon appears 1/4 to 1/2 second after said effect.

I provided a savestate for you to test with. All you have to do is push A (B on an Xbox controller) Bahamut.Lagoon.zip .

orbea commented 2 years ago

I cant load the state with the latest commit for bsnes, is there something specific that needs to be done?

jjohnson652 commented 2 years ago

That’s odd - not that I’m aware of. Perhaps there’s a ROM mismatch? I’ll look up the details of the ROM it was generated under. It was also generated on v115, not any commits thereafter.

We could also try the save file though you would have to go through several cutscenes before testing.

From my iPhone


From: orbea @.> Sent: Monday, April 18, 2022 10:21:13 AM To: bsnes-emu/bsnes @.> Cc: Johnson, Jared T @.>; Author @.> Subject: Re: [bsnes-emu/bsnes] Bahamut Lagoon audio sync issue (Issue #244)

I cant load the state with the latest commit for bsnes, is there something specific that needs to be done?

— Reply to this email directly, view it on GitHubhttps://github.com/bsnes-emu/bsnes/issues/244#issuecomment-1101492532, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ASQMJZBCZ4OSIKQ2O2YOIRLVFV4WTANCNFSM5SPPPKPA. You are receiving this because you authored the thread.Message ID: @.***>

orbea commented 2 years ago

This was reproducible with the save file. We would need to test this on real hardware to ensure this is not a game bug.

carmiker commented 2 years ago

https://youtu.be/kvTHHLRBU9k?t=23 Looks like a game bug to me, assuming this video was captured on real hardware. It is at least the untranslated version, so we know the translation did not introduce it.

jjohnson652 commented 2 years ago

Without knowing whether that was recorded on original game hardware or emulator with Japanese ROM, I’m not sure we can conclude that. Additionally the timing difference is greater in the video than what I saw.

It’s possible it’s a real game bug but I was unable to find a video definitely recorded on hardware.

From my iPhone


From: Rupert Carmichael @.> Sent: Monday, April 18, 2022 12:20:07 PM To: bsnes-emu/bsnes @.> Cc: Johnson, Jared T @.>; Author @.> Subject: Re: [bsnes-emu/bsnes] Bahamut Lagoon audio sync issue (Issue #244)

https://youtu.be/kvTHHLRBU9k?t=23 Looks like a game bug to me.

— Reply to this email directly, view it on GitHubhttps://github.com/bsnes-emu/bsnes/issues/244#issuecomment-1101582091, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ASQMJZGANEEKRUG532SJIB3VFWKUPANCNFSM5SPPPKPA. You are receiving this because you authored the thread.Message ID: @.***>

carmiker commented 2 years ago

I tested it on the Super Nt and got the same result as the video. This does not confirm behaviour on the SNES but it does lend credibility to the idea that this is just how the game is.

jjohnson652 commented 2 years ago

Ah! Yes, I would tend to think so too then. It LOOKS like the effects and sound should be synced but that could be wrong, or alternatively, could be an unaddressed error in the game itself. Nevertheless, unless someone has access to a real SFC and cartridge (I don’t; my SNES is NTSC) you can probably ignore this one.

From my iPhone


From: Rupert Carmichael @.> Sent: Monday, April 18, 2022 12:47:54 PM To: bsnes-emu/bsnes @.> Cc: Johnson, Jared T @.>; Author @.> Subject: Re: [bsnes-emu/bsnes] Bahamut Lagoon audio sync issue (Issue #244)

I tested it on the Super Nt and got the same result as the video. This does not confirm behaviour on the SNES but it does lend credibility to the idea that this is just how the game is.

— Reply to this email directly, view it on GitHubhttps://github.com/bsnes-emu/bsnes/issues/244#issuecomment-1101602641, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ASQMJZEK2YLW3UNF3POFSRLVFWN4VANCNFSM5SPPPKPA. You are receiving this because you authored the thread.Message ID: @.***>