Open Marat-Tanalin opened 1 year ago
Looks like this change was introduced in v084r05 (6227974bf68907cbeef021ed03f07adb60463a32), and probably has gone unnoticed for this long because these defaults are immediately overwritten as soon as the game reads the emulated controller state (and bsnes polls its mapped controllers).
It should probably still be fixed, though.
I agree with Screwtape; why not turn player1
and player2
into two elements of an array while we're at it? Copypasta is how these kinds of mistakes happen, in my experience.
Potential typo in
bsnes/sfc/controller/justifier/justifier.cpp
. The code contains two groups of similar statements, first group sets properties ofplayer1
, second group does the same forplayer2
:But the last line of the first group contains
player2
instead ofplayer1
. This might be a bug, not just because of obvious grouping, but also given that the second group contains the same statementplayer2.start = false;
too, and such duplication is unlikely intentional.