search

bsnes-emu / bsnes

bsnes is a Super Nintendo (SNES) emulator focused on performance, features, and ease of use.
Other
1.63k stars 154 forks source link

Option to disable IPS softpatch warning #285

Open ValiantBlade opened 1 year ago

ValiantBlade commented 1 year ago

I know the IPS softpatch warning is there for a reason, but usually for my IPS-patched ROMs I like to keep them in the format of ROM+IPS file. The reason for this is because it makes scanning ROMs with a front-end of some kind a lot easier, since most of those use CRC checksums, and the IPS hardpatch process disrupts that.

BPS can only be hardpatched so any BPS patched ROM also usually doesn't load into a frontend properly, and it just saves me time and headaches to use a ROM+IPS for most things. However I am aware IPS sucks for a lot of reasons, but since I play a lot of older fan-translations of RPGs, most of the time BPS files aren't even made available.

The vast majority of ROMs today are unheadered, and the warning is pretty much superfluous to most users, especially since most people who aren't using pre-patched ROMs are likely already making sure their checksums match the ones listed on ROMHacking.net. So for me, the warning is just a nag dialog telling me what I already know, that prevents me from properly using the CMD to launch a game seamlessly using a frontend of some kind, without hardpatching and jumping through hoops to make a frontend read it properly.

I don't think there should be no warning, just maybe one when a headered ROM and an IPS file to softpatch are detected. Because that is where the majority of IPS patch conflicts arise, and if an IPS patch needs a header for whatever reason, that's likely something the user of the hack likely knows going in.

jeffythedragonslayer commented 1 year ago

Is there a proposed syntax for this feature?