search

bsnes-emu / bsnes

bsnes is a Super Nintendo (SNES) emulator focused on performance, features, and ease of use.
Other
1.63k stars 154 forks source link

nall: Add needed #include <stdexcept> #286

Closed Screwtapello closed 1 year ago

Screwtapello commented 1 year ago

Taken from ares commit 6a7898396a14eef257e63cd002fb26ffbf6e2581

Apparently this is needed by GCC 13.

orbea commented 1 year ago

I thought I already fixed this?

https://github.com/bsnes-emu/bsnes/pull/274

Screwtapello commented 1 year ago

Ah, crud. Somebody reported this in higan, copying the fix from ares, and the same fix wasn't in bsnes so I assumed I'd have to port it there too. Sorry about that!

orbea commented 1 year ago

The way files are included in nall it makes sense there are multiple viable places to put this include, ares has also continued to develop nall so it perhaps the fixes will not be 1:1 with their copy?

Screwtapello commented 1 year ago

I think Near continued to develop nall in higan long before ares forked off, so trying to update nall to match the latest version would probably be quite the effort. I haven't actually tried it myself, though!

orbea commented 1 year ago

There is an issue for that. https://github.com/bsnes-emu/bsnes/issues/202