search

bsnes-emu / bsnes

bsnes is a Super Nintendo (SNES) emulator focused on performance, features, and ease of use.
Other
1.63k stars 154 forks source link

wdc65816: fix PLB wrapping in emulation mode #300

Closed Morilli closed 8 months ago

Morilli commented 8 months ago

Cherry-picked https://github.com/ares-emulator/ares/commit/e589f8d9cf1aaf04b1959bfc7d7085cb3861149c. I've checked and confirmed this does fix the test in question. Note that this does not fix the additional tests from version 1.2 of the cpu test rom.

Screwtapello commented 8 months ago

For my own future reference, the current version of bsnes passes all the tests in spctests.sfc v1.2. For cputests.sfc v1.2, it fails tests 0027, 0074, 015F, 0194, 0216, 02CC, 030B, 0397, 03D9, 046F, 04E0, 0518, 05D2, 0621 — all the tests listed as testing undocumented behaviour.

On this branch, test 03d9 now passes, which is the PLB test, which is good.

I also saw test 0194 intermittently passing, but I can't figure out how to reproduce that glitch, so I'm going to ignore it for now. Thanks for contributing!

orbea commented 8 months ago

@Screwtapello Just for reference the 0194 test doesn't fail every run, this indicates that there is something wrong in the test or that bsnes has indeterminate behavior.

Edit: I see now you mentioned this and I didn't read your entire comment correctly the first time.