search

bsnes-emu / bsnes

bsnes is a Super Nintendo (SNES) emulator focused on performance, features, and ease of use.
Other
1.68k stars 156 forks source link

Implementation of SA-1 BW-RAM protection #312

Closed Morilli closed 7 months ago

Morilli commented 7 months ago

Manually cherry-picked ares commit https://github.com/ares-emulator/ares/commit/70f361094b2983bc783957083be9d7d46cf39bf2.

Testing with the test rom from https://github.com/absindx/SNES-TestRoms/tree/267b128a84afdd250a51967963fa7fba4184399e/SA1RamProtectionTest, the following previously failing tests now pass:

2, 6, 39-66, 93-118, 155, 157-166, 168, 172, 179-190, 192, 194, 195, 198, 199, 203, 204, 208, 209, 211, 213, 215, 216* (test 216 freezes and doesn't allow progressing to further tests).

orbea commented 7 months ago

@Morilli and @Screwtapello

Was this tested against real hardware or only with the SD2SNES? Could it be a concern that this is emulating the SD2SNES implementations of SA-1 rather than the original hardware?