feat: implemented Navbar

bsoc-bitbyte / GetIt

Streamlined college e-commerce: Simplifying merch buying and selling for students.

https://getit.iiitdmj.ac.in/

17 stars 51 forks source link

feat: implemented Navbar #11

Closed whizzy23 closed 1 year ago

whizzy23 commented 1 year ago

Overview

This PR fixes or fixes part of #4 .
This PR does the following : Created a fully responsive navbar for all devices .

https://github.com/bsoc-bitbyte/GetIt/assets/129520458/2905267a-f998-476a-9e34-708867a417c3

Essential Checklist

[x] The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
[x] "Allow edits from maintainers" is checked. (See here for instructions on how to enable it.)
[x] The PR is made from a branch that's not called "main/master".

Proof that changes are correct

PR Pointers

If you need a review or an answer to a question, and don't have permissions to assign people, leave a comment like the following: "{{Question/comment}} @{{reviewer_username}} PTAL".
Never force push. If you do, your PR will be closed.

thejaysharma commented 1 year ago

hey @whizzy23, It is required to use tailwindcss for styling.

whizzy23 commented 1 year ago

@thejaysharma I already asked @tushitshukla03 before starting , he told me to use whatever I am comfortable with .

arminpatel commented 1 year ago

@whizzy23 incase you are not using tailwind css, create an issue that to fix that so that we can keep track of things

whizzy23 commented 1 year ago

Thanks @arminpatel . I'll keep it mind .

Priyansh61 commented 1 year ago

@thejaysharma @JawHawk @tushitshukla03 Do you think that we should use a standarised font and what should it be ?

whizzy23 commented 1 year ago

@Priyansh61 I used other font earlier , and used this(Poppins) later on as suggested by @tushitshukla03 Screenshot_2023-06-12-10-51-09-74_572064f74bd5f9fa804b05334aa4f912 It was the one i used earlier

whizzy23 commented 1 year ago

Regarding the font , I have used Poppins as suggested by @tushitshukla03 so I haven't changed it .

whizzy23 commented 1 year ago

Done with all the changes , compressed image , removed unnecessary file , placed images in assets folder and changed name from pages to nav-link

thejaysharma commented 1 year ago

Hey @whizzy23 push your changes so that we can review and merge the PR.

whizzy23 commented 1 year ago

Hey @thejaysharma I pushed the changes . Please review

whizzy23 commented 1 year ago

Hey @Priyansh61 please delete the package-lock file again and review this PR .

whizzy23 commented 1 year ago

Hey @Priyansh61 please add label to this pr

Priyansh61 commented 1 year ago

@whizzy23 Done