product page - Githubissues

bsoc-bitbyte / GetIt

Streamlined college e-commerce: Simplifying merch buying and selling for students.

https://getit.iiitdmj.ac.in/

18 stars 51 forks source link

product page #13

Closed rrtk857 closed 1 year ago

rrtk857 commented 1 year ago

Overview

This PR fixes or fixes part of #9
This PR does the following: This PR contain product page design with the use of API, HTML, CSS, JavaScript. the Product page has information about product and images, and buttons to buy it or add to cart.

Essential Checklist

[x] The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
[x] "Allow edits from maintainers" is checked. (See here for instructions on how to enable it.)
[x] The PR is made from a branch that's not called "main/master".

Proof that changes are correct

PR Pointers

If you need a review or an answer to a question, and don't have permissions to assign people, leave a comment like the following: "{{Question/comment}} @{{reviewer_username}} PTAL".
Never force push. If you do, your PR will be closed.

arminpatel commented 1 year ago

@rrtk857 in case you wouldn't be updating your PR to use tailwind css, create an issue to fix this

rrtk857 commented 1 year ago

@arminpatel, I will try to update it.

Priyansh61 commented 1 year ago

@JawHawk @tushitshukla03 PTAL!

Priyansh61 commented 1 year ago

Hey @rrtk857 Please address the above comments. If you need any help do let us know :)

rrtk857 commented 1 year ago

@arminpatel @thejaysharma @Priyansh61, Thanks for all the suggestions, I'll update my PR accordingly. I have few doubts regarding tailwind CSS, I have installed it according to the given instructions, but I am bit confused in Step 2,3. I am unable to understand where I have to include these files, so I have included it in the page folder only and it is working also. So, I am attaching the screenshots below, please check it once that it is right, or I have to do any other changes. Screenshot (41) Screenshot (42) Screenshot (43) Screenshot (44) Screenshot (45)