search

bsoc-bitbyte / GetIt

Streamlined college e-commerce: Simplifying merch buying and selling for students.
https://getit.iiitdmj.ac.in/
18 stars 51 forks source link

Fix #161 - make releases easily #162

Closed Adi8712 closed 6 months ago

Adi8712 commented 6 months ago

Overview

  1. This PR fixes #161 .
  2. This PR does the following: Uses release-it to setup a more developer-friendly method to make releases and updates changelog.md file automatically

Proof that changes are correct

Screenshot from 2024-04-15 15-34-12

netlify[bot] commented 6 months ago

Deploy Preview for merch-site ready!

Name Link
Latest commit e58fdc4df1fc1d6fd605a643c87bfe2dc2279378
Latest deploy log https://app.netlify.com/sites/merch-site/deploys/6621047a6baec800080576b6
Deploy Preview https://deploy-preview-162--merch-site.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Priyansh61 commented 6 months ago

@Adi8712 SInce generally we are after the release so shouldnt it be > v1.0.0 ?

Adi8712 commented 6 months ago

There's been no release as of yet so I assumed we'll test it and then go ahead with release v1

Adi8712 commented 6 months ago

@Priyansh61 I have set the version to 1.0.1 and emptied the changelog.md file Use npm run release and it should work

Adi8712 commented 6 months ago

@arminpatel The way I planned it after seeing the issue is using release-it as a dedicated tool for handling releases and in future automating release-it using GitHub actions. Although GitHub actions can help automate literally anything using a dedicated tool for releases seems more flexible and easier I guess.

arminpatel commented 6 months ago

@arminpatel The way I planned it after seeing the issue is using release-it as a dedicated tool for handling releases and in future automating release-it using GitHub actions. Although GitHub actions can help automate literally anything using a dedicated tool for releases seems more flexible and easier I guess.

The way I see it, assuming both methods provide the same functionality, using actions would remove unnecessary code from the project, save extra setup steps for the contributors.

@Priyansh61 wdyt?

Priyansh61 commented 6 months ago

@arminpatel The way I planned it after seeing the issue is using release-it as a dedicated tool for handling releases and in future automating release-it using GitHub actions. Although GitHub actions can help automate literally anything using a dedicated tool for releases seems more flexible and easier I guess.

The way I see it, assuming both methods provide the same functionality, using actions would remove unnecessary code from the project, save extra setup steps for the contributors.

@Priyansh61 wdyt?

Yup!! Ig @arminpatel pointed out the right thing it would be better to get more things off from the local setup and try to get things more in automation.. So I believe using GH actions would be much better.

Adi8712 commented 6 months ago

@Priyansh61 @arminpatel I looked into it and found GH Release. I guess this'll do, my only question is how do I take care of the GitHub token, I can set it up for my fork but someone has to do it for this repo as well I guess.

arminpatel commented 6 months ago

@Priyansh61 @arminpatel I looked into it and found GH Release. I guess this'll do, my only question is how do I take care of the GitHub token, I can set it up for my fork but someone has to do it for this repo as well I guess.

I would add the token needed, message me the details. Also can you explore other gh actions? We don't need to make releases just automated versioning is enough