Fix #24 : Removes white space from bottom of Sign-in page

[Akash1965]

Overview

1. This PR fixes or fixes part of #24 .
2. This PR does the following: Removes the extra white space at the bottom of the Sign-in page by making height: 100vh and changing the padding py-[2rem] to pt-[2rem].

Essential Checklist

• [x] The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
• [x] "Allow edits from maintainers" is checked. (See here for instructions on how to enable it.)
• [x] The PR is made from a branch that's not called "main/master".

Proof that changes are correct

PR Pointers

• If you need a review or an answer to a question, and don't have permissions to assign people, leave a comment like the following: "{{Question/comment}} @{{reviewer_username}} PTAL".
• Never force push. If you do, your PR will be closed.

[netlify[bot]]

✅ Deploy Preview for merch-site ready!

Name	Link
🔨 Latest commit	d6b089e4431618e98952c8088e80fd6779f0fb71
🔍 Latest deploy log	https://app.netlify.com/sites/merch-site/deploys/6497110646308b000815616b
😎 Deploy Preview	https://deploy-preview-29--merch-site.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[Priyansh61]

@Akash1965 On checking the deploy preview, the bug is still there on signup page

[Priyansh61]

@Akash1965 Please close the other PR and continue your work on this only, since it becomes really difficult to track 2 PRs for same thing

[Akash1965]

Okay

[Akash1965]

@Priyansh61 but on my browser the margin is removed after doing the changes that were mentioned in the other PR

[Akash1965]

I am committing the same changes again in this PR only......just check once if the white margin is still there or not

[Akash1965]

This is the sign up page on my browser

[Akash1965]

This is the Sign-in page on my browser

[pred695]

Hey @Akash1965 you can just check the mobile view and the desktop view by going to the responsiveness section of your browser.

[Akash1965]

Also when I am doing deploy preview it's shpwing that the white margin has been removed

[Akash1965]

Hey @Predcodes69 white margin isn't there in both the desktop and mobile view. I checked just now

[pred695]

Is the code same as the last pr? if it is so, I will check it. If it is not, please send the code in discord.

[Priyansh61]

@Akash1965 Try it out on 100% or less zoom and lemme know what you see on signup page?

[Akash1965]

@Predcodes69 Yes it's the same

[Akash1965]

@Priyansh61 okay

[Akash1965]

@Priyansh61 on 100% zoom the white margin is visible on sign in page I'll look into this issue

[Priyansh61]

@Akash1965 Great! Take a look and loop me in if you need any help.

[Akash1965]

@Priyansh61 Hi I have resolved the issue. Please check once

[Akash1965]

I have set the min-height: 100vh when min-height: 977px using the zoom class

[thejaysharma]

@Akash1965 white space isn't removed. It is still visible there..

[thejaysharma]

@Akash1965 Any updates?

[pred695]

I can fix the issue if possible.

[thejaysharma]

@Predcodes69 Sure! Fix it as soon as possible.

[pred695]

Ok sure sir @thejaysharma, on it.