Fix #24 : Removes white space from the bottom of Sign-in and Sign-up pages - Githubissues

bsoc-bitbyte / GetIt

Streamlined college e-commerce: Simplifying merch buying and selling for students.

https://getit.iiitdmj.ac.in/

18 stars 51 forks source link

Fix #24 : Removes white space from the bottom of Sign-in and Sign-up pages #32

Closed Akash1965 closed 1 year ago

Akash1965 commented 1 year ago

Overview

This PR fixes or fixes part of #24 .
This PR does the following: Removes the extra white space at the bottom of the Sign-in page by adding h-screen and changing the padding from py-[2rem] to pt-[2rem]. Also removes the extra white space at the bottom of the Sign-up page by removing h-screen.

Essential Checklist

[x] The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
[x] "Allow edits from maintainers" is checked. (See here for instructions on how to enable it.)
[x] The PR is made from a branch that's not called "main/master".

Proof that changes are correct

Screenshot (26) Screenshot (21) Screenshot (23) Screenshot (24) Screenshot (22)

PR Pointers

If you need a review or an answer to a question, and don't have permissions to assign people, leave a comment like the following: "{{Question/comment}} @{{reviewer_username}} PTAL".
Never force push. If you do, your PR will be closed.

netlify[bot] commented 1 year ago

Deploy Preview for merch-site ready!

Name	Link
Latest commit	5dbc8009df3f1ab18da1fa6332d71269a163ef49
Latest deploy log	https://app.netlify.com/sites/merch-site/deploys/64946a3e0d65b2000793f805
Deploy Preview	https://deploy-preview-32--merch-site.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.