bsoc-bitbyte / GetIt

Streamlined college e-commerce: Simplifying merch buying and selling for students.
https://getit.iiitdmj.ac.in/
17 stars 51 forks source link

fixed the posiiton of the buttons #53

Closed shramanpaul closed 1 year ago

shramanpaul commented 1 year ago

Overview

  1. This PR fixes or fixes part of #[27].
  2. This PR does the following: [fixes the position of add to cart and buy now buttons at the bottom]

Essential Checklist

Proof that changes are correct

https://github.com/bsoc-bitbyte/GetIt/assets/110323017/41a2762a-fdc2-4d74-ac51-2a657512fb61

PR Pointers

@Priyansh61 PTAL

netlify[bot] commented 1 year ago

Deploy Preview for merch-site ready!

Name Link
Latest commit 3ef42d7b2bdb109e6aafb933ced3b2901ecd2b9b
Latest deploy log https://app.netlify.com/sites/merch-site/deploys/64ad74a07cd1b600082bde20
Deploy Preview https://deploy-preview-53--merch-site.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

shramanpaul commented 1 year ago

https://github.com/bsoc-bitbyte/GetIt/assets/110323017/529a4b2e-3a06-4a2f-a906-06699749a1ad

@Priyansh61 PTAL

shramanpaul commented 1 year ago

https://github.com/bsoc-bitbyte/GetIt/assets/110323017/84877bd3-c201-44b4-b7be-6c46b0caf952

@Priyansh61 @thejaysharma I have made the changes as requested PTAL.

shramanpaul commented 1 year ago

https://github.com/bsoc-bitbyte/GetIt/assets/110323017/64180207-db41-44ac-9bc7-8932abcb7965

@Priyansh61 @prernadabi23 @thejaysharma made the requested changes similar to the Figma design provided PTAL

shramanpaul commented 1 year ago

made the changes as requested @prernadabi23 PTAL

tushitshukla03 commented 1 year ago

@shramanpaul both button length is not equal. Also add to cart icon is not aligned correctly image

Change the icon. Icons are white not black so instead of using black icon and inverting it to white use white only as sometimes browser or tailwind dont support this.

check font size and font family should be poppins.

prernadabi23 commented 1 year ago

Any updates? @shramanpaul

shramanpaul commented 1 year ago

@prernadabi23 the changes have been made I will be making the PR soon

prernadabi23 commented 1 year ago

Sure, please ensure that it is done before tonight and resolve the conflicting issues as well. @shramanpaul

shramanpaul commented 1 year ago

@tushitshukla03 @prernadabi23 @thejaysharma @Priyansh61 PTAL

shramanpaul commented 1 year ago

@tushitshukla03 PTAL