search

bsoc-bitbyte / GetIt

Streamlined college e-commerce: Simplifying merch buying and selling for students.
https://getit.iiitdmj.ac.in/
17 stars 51 forks source link

Adds Navbar to all the Routes #75

Closed rrtk857 closed 1 year ago

rrtk857 commented 1 year ago

Overview

  1. This PR fixes or fixes part of #23 .
  2. This PR does the following: adds navbar to all the Routes

Essential Checklist

Proof that changes are correct

PR Pointers

Screenshot (75)

Screenshot (76) Screenshot (77) checkout signup

netlify[bot] commented 1 year ago

Deploy Preview for merch-site ready!

Name Link
Latest commit 672f54652e0dbca081f18208d0340752d81ce10e
Latest deploy log https://app.netlify.com/sites/merch-site/deploys/64b10fb08f338000080bae5e
Deploy Preview https://deploy-preview-75--merch-site.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

rrtk857 commented 1 year ago

@prernadabi23 @thejaysharma @tushitshukla03 @Priyansh61, please review it.

rrtk857 commented 1 year ago

@Priyansh61, I have made all the changes, please review it.

tushitshukla03 commented 1 year ago

@rrtk857 Navbar is not visible in any route

rrtk857 commented 1 year ago

@tushitshukla03, I have resolved it.

tushitshukla03 commented 1 year ago

@rrtk857 it is still not visible please check before commiting

rrtk857 commented 1 year ago

@tushitshukla03 Sir, I have now included layouts outside nuxt directory. Please check whether it is working or not as it is working on my localhost.

tushitshukla03 commented 1 year ago

@rrtk857 don't write whole navbar code in layout instead just import the navbar component in layout to use

Priyansh61 commented 1 year ago

@rrtk857 Is there a way we can just make changes to the layout or navbar file and rest everything works, like we can just use the layout in the future pages and dont need to make any changes?

rrtk857 commented 1 year ago

@rrtk857 Is there a way we can just make changes to the layout or navbar file and rest everything works, like we can just use the layout in the future pages and dont need to make any changes?

Okay, I will try.