Fix #75: Added an admin page layout

bsoc-bitbyte / busify

A centralised bus ticket booking system that will allow the students to book tickets in advance through an online website, saving time and effort.

https://busify.vercel.app

30 stars 67 forks source link

Fix #75: Added an admin page layout #77

Closed Om-Thorat closed 4 weeks ago

Om-Thorat commented 1 month ago

Overview

This PR fixes or fixes part of #75 .
This PR does the following:
- Creates an admin page layout so that the other pages can be made with reusable component.
- Aligns all the contents in it within a grid to ensure responsiveness.

Essential Checklist

[x] The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
[x] "Allow edits from maintainers" is checked. (See here for instructions on how to enable it.)
[x] The PR is made from a branch that's not called "main/master".

Proof that changes are correct

PR Pointers

The footer currently isn't included in the Adminlayout, but i have left space for it if feasible during a future refactor of app.tsx needed to conditionally render the footer and navbar for admin layout differently.

vercel[bot] commented 1 month ago

@Om-Thorat is attempting to deploy a commit to the Busify Team on Vercel.

A member of the Team first needs to authorize it.

Pratik2026 commented 1 month ago

@Om-Thorat Nice work! so far the code looks clean to me.

About the footer and navbar, you can use the useLocation hook to conditionally render the already available navbar & footer on the basis of route(use /adminpanel/component_name route). This will allow you to incorporate different navbar for the admin pages.

Om-Thorat commented 1 month ago

Screenshots according to new commit.

Pratik2026 commented 1 month ago

@Om-Thorat I can still see the manage buses button on the top right corner in the Navbar when navigating to the admin page as an "Admin" role but your screenshot indicates otherwise.

Pratik2026 commented 1 month ago

I think you have not set the conditional rendering on the manage buses button since I can't see any changes made in that specific block of code.

Also, instead of adding new screenshots in the comments, please update the existing ones in the PR description itself.

Om-Thorat commented 4 weeks ago

@Om-Thorat I can still see the manage buses button on the top right corner in the Navbar when navigating to the admin page as an "Admin" role but your screenshot indicates otherwise.

Might have been overlooked because of not having an admin role, will fix.

Om-Thorat commented 4 weeks ago

@Pratik2026 Pushed a commit Implementing the suggestion. The screenshots remain the same. PTAL

Pratik2026 commented 4 weeks ago

@Om-Thorat LGTM.

Pratik2026 commented 4 weeks ago

merged, thanks for contributing @Om-Thorat