bsoc-bitbyte / busify

A centralised bus ticket booking system that will allow the students to book tickets in advance through an online website, saving time and effort.
https://busify.vercel.app
30 stars 67 forks source link

fix(frontend): responsiveness for BusDetailsCard component #78

Closed Zapper9982 closed 1 month ago

Zapper9982 commented 1 month ago

Overview

  1. This PR fixes or fixes part of #76 .
  2. This PR does the following: Makes the BusDetailsCard component responsive .

Essential Checklist

Proof that changes are correct

image ## PR Pointers - If you need a review or an answer to a question, and don't have permissions to assign people, **leave a comment** like the following: "{{Question/comment}} @{{reviewer_username}} PTAL". - Never force push. If you do, your PR will be closed.
vercel[bot] commented 1 month ago

@Zapper9982 is attempting to deploy a commit to the Busify Team on Vercel.

A member of the Team first needs to authorize it.

Pratik2026 commented 1 month ago

@Zapper9982, you were not supposed to change the alignment. All the components should be in a single row for tablets & laptops just as they were previously. All you need to do is reduce the gap, icon size, and font size as required.

Furthermore, the divider is still not visible on the tablet.

Pratik2026 commented 1 month ago

Also, it is already mentioned in the contribution.md that the PR must be made from a separate branch instead of the main/master branch. Please read it carefully before making a PR.

Zapper9982 commented 1 month ago

ill Take care of it from the next time , also i shall fix the missing divider in tablet mode and the alignment of all components in the tablet and laptop mode