bsoc-bitbyte / busify

A centralised bus ticket booking system that will allow the students to book tickets in advance through an online website, saving time and effort.
https://busify.vercel.app
30 stars 67 forks source link

Fixes #82 fix(components): update styling for the resuable card components #84

Closed ritankarsaha closed 3 weeks ago

ritankarsaha commented 4 weeks ago

Overview

  1. This PR fixes or fixes part of #82 .
  2. This PR does the following: This PR contains reusable card components for the upcoming and completed bus cards in the components folder of the src folder of the frontend folder of the project.

Essential Checklist

Proof that changes are correct

Screenshot 2024-06-05 at 2 44 45 AM Screenshot 2024-06-05 at 3 11 42 AM

This is the first reusable card component showing that it is responsive across all devices. this is the upcoming component.

Screenshot 2024-06-05 at 2 49 56 AM Screenshot 2024-06-05 at 3 12 38 AM

This is the second reusable card component that is being used here. this is the completed component.

The data in these cards are not hardcoded and are rendered creating a new route path in the App.jsx file giving appropriate demo data there to display the card components successfully. The components are ready to be rendered anywhere in the project efficiently from the components folder.

Thank You

PR Pointers

vercel[bot] commented 4 weeks ago

@ritankarsaha is attempting to deploy a commit to the Busify Team on Vercel.

A member of the Team first needs to authorize it.

ritankarsaha commented 4 weeks ago

@RISHIKESHk07 I have fixed the issue #82 and also opened a PR for the same. #82 .

ritankarsaha commented 3 weeks ago

@RISHIKESHk07 Made the necessary changes and pushed a new commit.

ritankarsaha commented 3 weeks ago

@RISHIKESHk07 Made the necessary changes to the card components.

PROOF OF WORK:-

Screenshot 2024-06-05 at 8 27 24 PM Screenshot 2024-06-05 at 8 27 10 PM

Thank You.

RISHIKESHk07 commented 3 weeks ago

@ritankarsaha a photo of the completed as well please , @Pratik2026 any changes ?

ritankarsaha commented 3 weeks ago

@ritankarsaha a photo of the completed as well please , @Pratik2026 any changes ?

@RISHIKESHk07 I have already attached the photos of the final completed cards in the previous comment. I am attaching it once more.

Screenshot 2024-06-07 at 11 43 55 AM

Screenshot of the upcoming card.

Screenshot 2024-06-07 at 11 44 59 AM

Screenshot of the completed card.

Pratik2026 commented 3 weeks ago

@ritankarsaha The code looks fine but some font-sizes and font-weight are not according to the designs. You can check the properties of components in Figma itself. Try the dev mode of Figma, it will display the properties of selected components.

I have requested some changes which could have been given but I am expecting you to review yourself as well and change the properties wherever required.

ritankarsaha commented 3 weeks ago

@Pratik2026 Made all the necessary changes according to the figma design and as per as the review comments and pushed a new commit into the PR

Screenshot 2024-06-08 at 1 15 08 AM

Thank You

ritankarsaha commented 3 weeks ago

@Pratik2026 Made the necessary changes and pushed a new commit into the PR

Pratik2026 commented 3 weeks ago

@ritankarsaha, The changes looks good. Just do the final change and then we can proceed further.

ritankarsaha commented 3 weeks ago

@ritankarsaha, The changes looks good. Just do the final change and then we can proceed further.

@Pratik2026 Made the necessary change and pushed a new commit into the PR

Pratik2026 commented 3 weeks ago

LGTM.

Pratik2026 commented 3 weeks ago

merged, thanks for contributing @ritankarsaha

ritankarsaha commented 3 weeks ago

merged, thanks for contributing @ritankarsaha

Thank You @Pratik2026