Closed ritankarsaha closed 3 weeks ago
@ritankarsaha is attempting to deploy a commit to the Busify Team on Vercel.
A member of the Team first needs to authorize it.
@RISHIKESHk07 I have fixed the issue #82 and also opened a PR for the same. #82 .
@RISHIKESHk07 Made the necessary changes and pushed a new commit.
@RISHIKESHk07 Made the necessary changes to the card components.
PROOF OF WORK:-
Thank You.
@ritankarsaha a photo of the completed as well please , @Pratik2026 any changes ?
@ritankarsaha a photo of the completed as well please , @Pratik2026 any changes ?
@RISHIKESHk07 I have already attached the photos of the final completed cards in the previous comment. I am attaching it once more.
Screenshot of the upcoming card.
Screenshot of the completed card.
@ritankarsaha The code looks fine but some font-sizes and font-weight are not according to the designs. You can check the properties of components in Figma itself. Try the dev mode of Figma, it will display the properties of selected components.
I have requested some changes which could have been given but I am expecting you to review yourself as well and change the properties wherever required.
@Pratik2026 Made all the necessary changes according to the figma design and as per as the review comments and pushed a new commit into the PR
Thank You
@Pratik2026 Made the necessary changes and pushed a new commit into the PR
@ritankarsaha, The changes looks good. Just do the final change and then we can proceed further.
@ritankarsaha, The changes looks good. Just do the final change and then we can proceed further.
@Pratik2026 Made the necessary change and pushed a new commit into the PR
LGTM.
merged, thanks for contributing @ritankarsaha
merged, thanks for contributing @ritankarsaha
Thank You @Pratik2026
Overview
Essential Checklist
Proof that changes are correct
This is the first reusable card component showing that it is responsive across all devices. this is the upcoming component.
This is the second reusable card component that is being used here. this is the completed component.
The data in these cards are not hardcoded and are rendered creating a new route path in the App.jsx file giving appropriate demo data there to display the card components successfully. The components are ready to be rendered anywhere in the project efficiently from the components folder.
Thank You
PR Pointers