feat(frontend): added admin schedule page - Githubissues

bsoc-bitbyte / busify

A centralised bus ticket booking system that will allow the students to book tickets in advance through an online website, saving time and effort.

https://busify.vercel.app

30 stars 67 forks source link

feat(frontend): added admin schedule page #91

Closed bravichandra12 closed 2 weeks ago

bravichandra12 commented 2 weeks ago

Overview

This PR fixes or fixes part of [#90].
This PR does the following:
- Adds Admin Schedule Page

Essential Checklist

[ ] The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
[x] "Allow edits from maintainers" is checked. (See here for instructions on how to enable it.)
[x] The PR is made from a branch that's not called "main/master".

Proof that changes are correct

Screenshot (109) Screenshot (110)

vercel[bot] commented 2 weeks ago

@bravichandra12 is attempting to deploy a commit to the Busify Team on Vercel.

A member of the Team first needs to authorize it.

Pratik2026 commented 2 weeks ago

@bravichandra12, I might not have explicitly mentioned but the issue is to create a complete schedule page by which I meant to create the cards component involved in this schedule page as well.

Pratik2026 commented 2 weeks ago

Add the cards component as well with dummy data along with the requested changes as mentioned above and make sure to keep the page responsive as currently it does not seem so.

bravichandra12 commented 2 weeks ago

@Pratik2026 Sure I will add cards and make the page responsive

Pratik2026 commented 2 weeks ago

@bravichandra12, The card component should have only one card so that we can use that card component as a reusable UI card. Furthermore, the bus detail card header is not exactly the same as the designs. Changing the layout a bit using flex properties might fix it.

Pratik2026 commented 2 weeks ago

Also, currently, if we directly visit the schedule page then the selected tab is still the dashboard. This can be fixed by using useEffect in schedule page to change the activeTab state value according to the URL of the page.

bravichandra12 commented 2 weeks ago

Ok I will do the changes as mentioned

bravichandra12 commented 2 weeks ago

@Pratik2026 The changes are made accordingly

Pratik2026 commented 2 weeks ago

@bravichandra12, The changes look good to me. However, the layout is not responsive in mobile view. Currently, it's overflowing whenever you switch between the bus details and conductor details tab.

The reason behind this is that you have set the fixed width and height of each UI component which makes the the whole component completely rigid. We should always use max-width and max-height instead of the width & height property. This helps us in preventing the overflow.

bravichandra12 commented 2 weeks ago

Made the changes as mentioned

Pratik2026 commented 2 weeks ago

LGTM.

Pratik2026 commented 2 weeks ago

merged, thanks for the contribution @bravichandra12