Improve /ping command - Githubissues

bsoyka / blockbot

MIT License

0 stars 1 forks source link

Improve /ping command #1

Open bsoyka opened 3 years ago

bsoyka commented 3 years ago

The /ping command currently replies with only "I'm alive!" and needs some improvement.

Here are my ideas:

Make the response an embed.
Add the bot's latency
(Maybe) add the bot's uptime (copied from /stats)

My only concern with the final point is duplicating information unnecessarily, but I'd love to hear more thoughts on that.

I'm marking the status on this one as planning for now. I'd like to have at least a little discussion before anyone starts working on this.

Wiggle37 commented 3 years ago

I have created a pull request, it should work and look something like this

Edit: did not read the bottom part.....

LukeG294 commented 3 years ago

Since the purpose of the command is to ping the bot to see if it's up and its latency, how about an addition to the embed that says "x hours down today"? The unit could obviously be switched from "today" to something longer but downtime is something I'd like to see if I'm checking the condition of the bot. If I was experiencing an error earlier in the day and wanted to test if the bot was working and up now, it would be helpful to know that the bot is experiencing some repairs today and that was the problem (could even link to a status channel, although I doubt the bot will be down much except for restarting and maintenance).

bsoyka commented 3 years ago

@LukeG294 That's an interesting thought, but I'm not sure how we could efficiently track downtime, particularly considering the bot would be — as the name implies — down. Great idea, just not sure what the implementation would look like. (Also, that might be more suited for the /stats command.)

LukeG294 commented 3 years ago

Haha didn't think about that, makes sense and I agree it would fit better in stats. Not sure what you're using to host but maybe there's a way you can fetch it from there? Just a thought, I'll post here if I come up w/ anything for ping.

bsoyka commented 3 years ago

Alright, I'm gonna hold off on approving this issue until I have some contributing guidelines ready to go, along with info on setting up a test server and all that.