search

bsphere / node-gapitoken

Node.js Google API service account authorization
51 stars 19 forks source link

Improvements #13

Closed robertrossmann closed 9 years ago

robertrossmann commented 9 years ago

Added a bunch of improvements to the code. Some are just whitespace/formatting cleanup. The most important changes are:

  1. The public API is now truly async, meaning all callbacks will always be called in the next tick
  2. Added support for the kid header option (see here)

Please have a look and let me know if anything needs work. Thanks!

robertrossmann commented 9 years ago

@bsphere, any feedback on this? Are you per chance interested in another maintainer for this module...?

bsphere commented 9 years ago

I'm interested in additional maintainers..

On Wed, 25 Feb 2015 at 20:19 Robert Rossmann notifications@github.com wrote:

@bsphere https://github.com/bsphere, any feedback on this? Are you per chance interested in another maintainer for this module...?

— Reply to this email directly or view it on GitHub https://github.com/bsphere/node-gapitoken/pull/13#issuecomment-76022358.

bsphere commented 9 years ago

I reverted this PR, take a look at https://github.com/bsphere/node-gapitoken/issues/16