search

bspkrs-mods / bspkrsCore

A Minecraft mod to hold utility classes used in all the mods I develop/maintain.
30 stars 40 forks source link

Make it for newer version #39

Open RoARene317 opened 6 years ago

RoARene317 commented 6 years ago

I need a new version of bspkrs mod (The Minecraft version 1.12.2)

Plz made it

MichaelHillcox commented 5 years ago

It's on it's way 👍

Anora commented 4 years ago

1.14.4 would be nice as well

MichaelHillcox commented 4 years ago

Only just shipped 1.12, give me time haha :D

Aaronstar-McClure commented 3 years ago

@MichaelHillcox I noticed a 1.12 version was released. Are you going to put a copy in the ivy repo? I'm trying to update floating ruins to 1.12.2, and the deobf dependency is not resolving in gradle...

bspkrs commented 3 years ago

@Aaronstar-McClure I don't mean to discourage you from attempting the update, but know that it's not quite as simple as making sure it compiles again and doesn't crash... I did a 1.12 update on my own for fun, and I found that Forge was sending me warnings about my code not being chunk-safe. The generation code is forcing chunks that don't exist yet into existence. The official way to do generation of this type is to make it a proper Structure, similar to Villages or Strongholds.

MichaelHillcox commented 3 years ago

If you do plan on updating, please PR it to the main repo so we can ship the update. I've not had time to port that mod yet, nor update this mod to newer versions. It's a hard task porting up mods from older mods.

Aaronstar-McClure commented 3 years ago

I do have a PR for floating ruins right now, but it's still only a draft as I work on it. If you are referring to the cascading chunk gen warning I've seen that in a few other mods and it hasn't seemed to be fatal, I'll try it out and see what happens

MichaelHillcox commented 3 years ago

You'd likely want to go the correct route about it otherwise it'll just be harder to port to newer versions of MC. Generation code is a pain.

bspkrs commented 3 years ago

@Aaronstar-McClure It's not fatal in 1.12, but in newer versions it might be. Talk to the experts on the Forge Project discord if you need further help on that.