bspkrs / MCPMappingViewer

A small GUI for viewing the mappings from Minecraft obfuscated code names to MCP code names.
http://www.minecraftforum.net/topic/2115030-
MIT License
231 stars 50 forks source link

Can't load 1.11 mappings (FileNotFound Start.java) #14

Closed MiniDigger closed 7 years ago

MiniDigger commented 7 years ago

just tried to spin up MMV to look at some 1.11 stuff and saw that it can't load the mappings on my system. Loading 1.10 stable works just fine. http://i.minidigger.me/2016/12/javaw_06_20-01-42.png



java.io.FileNotFoundException: C:\Users\Martin\.cache\MCPMappingViewer\1.11\patches\Start.java (Das System kann den angegebenen Pfad nicht finden)
    at java.io.FileOutputStream.open0(Native Method)
    at java.io.FileOutputStream.open(Unknown Source)
    at java.io.FileOutputStream.<init>(Unknown Source)
    at java.io.FileOutputStream.<init>(Unknown Source)
    at bspkrs.mmv.RemoteZipHandler.extractZip(RemoteZipHandler.java:233)
    at bspkrs.mmv.RemoteZipHandler.checkRemoteZip(RemoteZipHandler.java:119)
    at bspkrs.mmv.McpMappingLoader.getSubDirForZip(McpMappingLoader.java:122)
    at bspkrs.mmv.McpMappingLoader.<init>(McpMappingLoader.java:85)
    at bspkrs.mmv.gui.MappingGui$RefreshActionListener$1.run(MappingGui.java:1148)```

I am on win 10  1607 64bit and java 8 u91 64bit. 
reproduced it on a clean win10 vm
bspkrs commented 7 years ago

Thanks, I am looking into this. Seems like it might be a problem with the way the srg zip files were created, so I'll let you know when it's resolved.

On Tue, Dec 6, 2016 at 2:09 PM, MiniDigger notifications@github.com wrote:

just tried to spin up MMV to look at some 1.11 stuff and saw that it can't load the mappings on my system. Loading 1.10 stable works just fine. [image: http://i.minidigger.me/2016/12/javaw_06_20-01-42.png] https://camo.githubusercontent.com/216863c1fa76b907f63b25ffae077b0fcc214bb1/687474703a2f2f692e6d696e696469676765722e6d652f323031362f31322f6a617661775f30365f32302d30312d34322e706e67

I am on win 10 1607 64bit and java 8 u91 64bit.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/bspkrs/MCPMappingViewer/issues/14, or mute the thread https://github.com/notifications/unsubscribe-auth/ABfT7nYzkZe1dXwBUD9FAyKVfuTaQev5ks5rFbLYgaJpZM4LFxp7 .

bspkrs commented 7 years ago

Doing builds for 1.0.1 to fix this. Thanks for reporting it.

bspkrs commented 7 years ago

I'm not sure why the page isn't refreshing for me, but you can download it from here: http://bspk.rs/MC/MCPMappingViewer/MCPMappingViewer_1.0.1.exe http://bspk.rs/MC/MCPMappingViewer/MCPMappingViewer_1.0.1.jar

MiniDigger commented 7 years ago

thanks for looking at it, will give it a try later today.

MiniDigger commented 7 years ago

that fixed it, thank you

LeafHacker commented 7 years ago

@bspkrs can you add 1.0.1 to the github releases tab?

This should happen automatically if you tag the relevant commit as 1.0.1:

git tag 1.0.1 95dd1c5
git push origin 1.0.1 # or "git push --tags" for all tags, normally "git push" ignores tags

Also, FYI mcp940-pre1 still has mapping viewer 1.0.0, probably because 1.0.1 isn't tagged as a release.