search

bspkrs / MCPMappingViewer

A small GUI for viewing the mappings from Minecraft obfuscated code names to MCP code names.
http://www.minecraftforum.net/topic/2115030-
MIT License
231 stars 50 forks source link

Try to use the new SRG location and format #19

Closed MattSturgeon closed 3 years ago

MattSturgeon commented 5 years ago

Fixes #18

I noticed that SRG mappings are no longer published to the mcpbot website, instead the Forge maven is being used.

The new mappings also use a new tree format tsrg over the old format, which I've crudely implemented in TSrgFile. Note a couple FIXMEs due to the new format apparently including less information than the old.

The new system will be used if mc_ver is 1.13 or greater, according to String.compareTo.

I've attached a zip containing a jar built from this branch in case anyone wishes to test this out without having to clone this branch and build it themselves (not that that would be difficult!) MCPMappingViewer-PR19.zip

MattSturgeon commented 5 years ago

Removed the println() and tidied up the ternaries a little in 3279b95

MattSturgeon commented 5 years ago

@bspkrs have you had a chance to re-review?

MattSturgeon commented 4 years ago

@bspkrs any chance of taking another look?

xcfrg commented 3 years ago

This PR breaks mappings for stable 1.9.4 and below, you can find my fix for it here: https://github.com/xcfrg/MCPMappingViewer/blob/master/src/main/java/bspkrs/mmv/McpMappingLoader.java#L80-L82

bspkrs commented 3 years ago

@xcfrg and @MattSturgeon: thanks for your work on this and sorry for taking so long to pull it in.