search

bspkrs / MCPMappingViewer

A small GUI for viewing the mappings from Minecraft obfuscated code names to MCP code names.
http://www.minecraftforum.net/topic/2115030-
MIT License
231 stars 50 forks source link

Fix wrong parsing of primitive multidimensional array parameters #27

Closed Netzwerkfehler closed 2 years ago

Netzwerkfehler commented 3 years ago

The regex for parsing method parameters has a small bug that causes primitive arrays to always be read as one-dimensional arrays, even if they have more dimensions. In addition, a redundant part was optimised.

Old regex: https://regex101.com/r/c34Rjs/1 New regex: https://regex101.com/r/3fbPGd/1

bspkrs commented 3 years ago

Thanks, I didn’t realize there was an issue. I will merge this next time I’m at my desk.

On Jul 30, 2021, at 11:38 AM, Netzwerkfehler @.***> wrote:

 The regex for parsing method parameters has a small bug that causes primitive arrays to always be read as one-dimensional arrays, even if they have more dimensions. In addition, a redundant part was optimised.

Old regex: https://regex101.com/r/c34Rjs/1 New regex: https://regex101.com/r/3fbPGd/1

You can view, comment on, or merge this pull request online at:

https://github.com/bspkrs/MCPMappingViewer/pull/27

Commit Summary

Fix wrong parsing of primitive multidimensional array parameters File Changes

M src/main/java/bspkrs/mmv/ExcData.java (4) Patch Links:

https://github.com/bspkrs/MCPMappingViewer/pull/27.patch https://github.com/bspkrs/MCPMappingViewer/pull/27.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.