search

bspkrs / Treecapitator

DaftPVF's Treecapitator mod for Minecraft. Chops down trees in a single blow. Requires bspkrsCore.
http://www.minecraftforum.net/topic/1009577-
42 stars 36 forks source link

Fix HarvestDropsEvent being bypassed when stackDrops is true #33

Open squeek502 opened 9 years ago

squeek502 commented 9 years ago

Should be safe to merge to 1.8 as well.

AlexPlus117 commented 8 years ago

Hi squeek, I tried to add the code you suggested (in my private modpack) and didn't work. Skill level of my axe still increases itself of 1 point, even if I cut a tree using TreeCapitator...

squeek502 commented 8 years ago

I never actually tested it with ITT. I'll try to do that later today.

AlexPlus117 commented 8 years ago

Thank you. Could I ask you to keep me updated on your tests, please?

squeek502 commented 8 years ago

Ah, @AlexPlus117, just realized that this isn't a fix for the ITT problem. Here's what I posted when I linked to this issue from the ITT issue:

I've submitted a pull request that fixes a similar incompatibility and it's gotten no action.

This PR fixes https://github.com/squeek502/VeganOption/issues/30, not the onBlockStartBreak issue that ITT needs. That will require a different fix.

AlexPlus117 commented 8 years ago

Ah, ok. If I don't annoy you, can you give me, privately, the fix for ITT problem, please?

squeek502 commented 8 years ago

I'd have to look into it a bit more. Once I do, I'll add the fix to this PR.

AlexPlus117 commented 8 years ago

Ok, thank you.

squeek502 commented 8 years ago

@AlexPlus117, sorry, but the fix that ITT needs is actually somewhat complicated--simply due to the fact that Treecapitator reimplements so much harvesting functionality that it's hard to figure out where onBlockStartBreak should be called and then detect and fix any unintended effects--and I'm not willing to invest the time necessary to figure everything out. You'll have to find someone more familiar with Treecapitator and who is willing to put in the effort to fix that.