Prevent spy-mode clients (i.e., console -s ...) from being promoted to console writer

bstansell / conserver

Logged, multi-user access to device consoles

https://www.conserver.com/

BSD 3-Clause "New" or "Revised" License

129 stars 38 forks source link

Prevent spy-mode clients (i.e., console -s ...) from being promoted to console writer #108

Closed beckerg closed 3 months ago

beckerg commented 3 months ago

This patch prevents console clients started explicitly in spy mode (e.g., console -s victim) from being promoted to console writer after a preexisting writer disconnects. It also makes the server produce more useful error messages when issued commands that cannot be executed while in spy mode.

See issue 107 https://github.com/bstansell/conserver/issues/107.

beckerg commented 3 months ago

Curious, make test completes successfully on my ubuntu-24, rocky-9.4, freebsd-13.3, and freebsd-14.1 VMs, not clear why this failed, nor how to re-run it in case it's a transient CI error...

beckerg commented 3 months ago

@bstansell I'm not able to assign a reviewer since I don't have sufficient permission...