search

bstansell / conserver

Logged, multi-user access to device consoles
https://www.conserver.com/
BSD 3-Clause "New" or "Revised" License
129 stars 38 forks source link

console: Add 'k' option to exit on console-down #54

Closed MyleneJ closed 3 years ago

MyleneJ commented 3 years ago

Hello,

This commit is adding an option 'k' to make the console application exits when the console is down.

This can be useful in some cases such as an integration to LAVA infrastructure. Console can be used to open a terminal on different boards to be able to run some tests. In some cases, the console is down and without this commit, the tests will be timed-out because it can't talk to the device. Adding this option will allow us to exit the console directly, without waiting for a timeout. The benefit will be time saving.

Signed-off-by: Mylène Josserand mylene.josserand@collabora.com

bstansell commented 3 years ago

Thanks for the PR. This sounds like a great idea - I'll just need to adjust the way it handles the exit, update the man page, etc.

MyleneJ commented 3 years ago

@bstansell Thank you very much! Oh, sorry about the man page, I forgot to update that. I can send you another pull-request with that if it is not too late :) Best regards, Mylène

MyleneJ commented 3 years ago

@bstansell Thank you very much! Oh, sorry about the man page, I forgot to update that. I can send you another pull-request with that if it is not too late :) Best regards, Mylène

Nevermind, I just saw your commit about updating the doc. Thank you again for your quick review and merge! Best regards, Mylène