search

bstaple1 / MTGA_Draft_17Lands

Magic: The Gathering Arena draft tool that utilizes 17Lands data
MIT License
110 stars 31 forks source link

Scryfall page for DMU returns cards without any arena_id which causes failure to download set data #21

Closed bikeboy99 closed 2 years ago

bikeboy99 commented 2 years ago

One of the URLs returned by the Scryfall API for DMU ('next_page') is this page:

https://api.scryfall.com/cards/search?format=json&include_extras=false&include_multilingual=false&include_variations=false&order=set&page=3&q=e%3Admu&unique=prints

Please note this is not for DMU Alchemy - this is for DMU.

Because it has no arena_id for any cards, this continue statement is triggered for each card. resultis never set to true and the application thinks that the overall download failed.

bikeboy99 commented 2 years ago

I was able to get it to work by modifying the code to track if there ever was a result for any page. I suppose this could lead to partial results in some cases. Just a temporary workaround.

bikeboy99 commented 2 years ago

Apologies - didn't mean to close the issue I don't use github often.

bstaple1 commented 2 years ago

Hi bikeboy99,

Thanks for bringing this to my attention. I haven't had time to play Magic recently, so I appreciate it when people report issues with the tool.

I will investigate this when I get a chance.

bstaple1 commented 2 years ago

@bikeboy99 version 3.04 has a fix for this issue.

Note: The auto-update feature in 3.03 is broken, so you will need to re-download the application from the release page.

Thanks for the help.