Is horrible, and is not at all species general. There are three separate files that get swapped in depending on if it is drift+set, drift only, or set only. The addition of combine_boot_out() (#194) will vastly streamline this (making that portion of these files general).
However, the bullet-generating code currently assumes all of Chinook, chum, and sockeye will be present and reported, and the same for sheefish and whitefish in the non-salmon case. The new functionality will allow users to select which species to report, thus this code needs to either (a) be expanded to add many new swappable files to choose from when the species are selected (obviously not the correct choice) or (b) create a function make_harvest_bullets(include_set_summary, nonsalmon) that automatically generates this bullet text. This will allow only one harvest estimation file to be swapped in for each the salmon and non-salmon sections, regardless of the selections of species or gear combos.
bstaton1
commented
1 year ago
The code that generates this content:
Is horrible, and is not at all species general. There are three separate files that get swapped in depending on if it is drift+set, drift only, or set only. The addition of
combine_boot_out()(#194) will vastly streamline this (making that portion of these files general).However, the bullet-generating code currently assumes all of Chinook, chum, and sockeye will be present and reported, and the same for sheefish and whitefish in the non-salmon case. The new functionality will allow users to select which species to report, thus this code needs to either (a) be expanded to add many new swappable files to choose from when the species are selected (obviously not the correct choice) or (b) create a function
make_harvest_bullets(include_set_summary, nonsalmon)that automatically generates this bullet text. This will allow only one harvest estimation file to be swapped in for each the salmon and non-salmon sections, regardless of the selections of species or gear combos.