search

bstopp / puppet-aem

Puppet module for managing AEM Installations.
https://forge.puppet.com/bstopp/aem
Apache License 2.0
30 stars 30 forks source link

Add param for systemd service options #114

Closed zipkid closed 5 years ago

zipkid commented 6 years ago

Allow configuring PrivateTmp in systemd service file https://stackoverflow.com/questions/41702332/attachnotsupportedexception-when-trying-to-start-a-jfr-recording/47664741#47664741

zipkid commented 6 years ago

I have changed this PR to allow setting any systemd service option instead of adding a param per option.

zipkid commented 6 years ago

I changed rubocop.yaml and set 'TargetRubyVersion' to 2.2 but codeclimate doesn't seem to pick up that change.

cliffano commented 5 years ago

Hello @bstopp . Any chance of this PR getting merged? I encounter many occurrences where the default TimeoutStopSec=4min is not enough, hence the SIGINT wouldn't make a difference anyway since AEM doesn't get a chance to gracefully stop.

bstopp commented 5 years ago

The PR only contains an update to remove the PrivateTmp service def. It still contains the TimeoutStopSec declaration here.

So this won't fix your issue @cliffano.

Let me look at this weekend and see we can get a full/arbitrary set of key/values.

cliffano commented 5 years ago

I was under the impression that the TimeoutStopSec could be redeclared again in the key value pairs and overwrites the default TimeoutStopSec=4min , and since systemd_service_options is a hash, the users would be able to inject anything.

Alternatively, can't the systemd_service_options defines a default hash that contains systemd_service_options: { 'TimeoutStopSec' => '4min', 'KillSignal' => 'SIGCONT', 'PrivateTmp' => true } ?

bdhoine commented 5 years ago

@bstopp @zipkid @cliffano can we revisit this PR? It would be nice if this go merged. As far as I can tell we need to tackle the last comment. I think it would be nice if the static config like TimeoutStopSec and KillSignal would be indeed replace by defining them in the systemd_service_options config hash.

zipkid commented 5 years ago

@bdhoine I will look at this next week.

bstopp commented 5 years ago

I'll probably close this in favor of #128. Release coming soon.

bstopp commented 5 years ago

@zipkid @bdhoine @cliffano Thanks for all the feedback and help with this. I had some issues trying to merge this change in, that's why i have a different branch with the updates. I'm also running into some issue with updating all the dev gem dependencies. Many of them have updates that require rewriting of large portions of the module, hence why not Gemfile version updates; look for those soon.