search

bstopp / puppet-aem

Puppet module for managing AEM Installations.
https://forge.puppet.com/bstopp/aem
Apache License 2.0
30 stars 30 forks source link

FR: Add support for secure renders #116

Closed Jarodiv closed 6 years ago

Jarodiv commented 6 years ago

For our current project secure communication between the Dispatcher and AEM is required. Currently that Dispatcher feature is not supported by this module.

See: https://helpx.adobe.com/experience-manager/dispatcher/using/dispatcher-configuration.html#DefiningPageRenderersrenders

dploeger commented 6 years ago

Created a PR for that. Be sure, to use the correct, SSL-enabled package, though.

Additionally, on an Ubuntu-16.04 I had to add two links to libcrypto.so.10 => libcrypto.so.1.0.0 and libssl.so.10 => libssl.so.1.0.0 in /lib/x86_64-linux-gnu for it to work. But that maybe an OS/AEM compilation issue.

Jarodiv commented 6 years ago

Thanks for spending time on this. There already is PR #117 that adds the same changes plus the corresponding tests and default values :)

dploeger commented 6 years ago

Oh, allright. Didn't catch that.

dploeger commented 6 years ago

@bstopp Can #117 be merged?

Jarodiv commented 6 years ago

@dploeger if you need that PR, as we did: we created a temporary fork in our companies account, that includes this PR (on master) and one for #124 on develop (not promoted to master yet). -> https://github.com/Netcentric/puppet-aem

That way @bstopp can take all the time he needs to validate and perform these merges.

dploeger commented 6 years ago

@Jarodiv Yes, we're using our branch from the PR currently, but using official version is always better. Especially as something like the metadata.json of Puppet modules doesn't understand git references.

Jarodiv commented 6 years ago

100% agree on that