search

bstopp / puppet-aem

Puppet module for managing AEM Installations.
https://forge.puppet.com/bstopp/aem
Apache License 2.0
30 stars 30 forks source link

Allowing literal values for file type OSGi configs. #90

Closed stevengssns closed 6 years ago

stevengssns commented 7 years ago

I need to be able to set the necessary OSGi configs for the S3SharedDataSource, but the puppet module will change the data I provide in an unexpected way:

This is the hiera data:

This is the resulting OSGi config:

service.pid="org.apache.jackrabbit.oak.plugins.blob.datastore.SharedS3DataStore" path="/data/apps/aem/datastore" s3Bucket="387323646340--aem-datastore" s3Region="eu-west-1" connectionTimeout=L"120000" maxConnections=L"40" maxErrorRetry=L"10" socketTimeout=L"120000"

However, values with a 'L' prefix should be normal strings for the plugin to work.

So this pull request would allow me to specify the values in a literal way, without them being changed. The change should also be backwards compatible.

bstopp commented 7 years ago

Can you write some test cases to go along with this?

Also: You should open a ticket against Jackrabbit. Properties that are numbers should accept numbers (as well as strings, if desired). Here's a link to the underlying code having the issue: https://github.com/apache/jackrabbit-oak/blob/trunk/oak-blob-cloud/src/main/java/org/apache/jackrabbit/oak/blob/cloud/s3/Utils.java#L198

stevengssns commented 7 years ago

Sorry about failed builds. I was having trouble with some of the ruby gems on my workstation.

Hopefully the tests I added are sufficient.

https://issues.apache.org/jira/browse/OAK-6446

stevengssns commented 6 years ago

Hi, any updates on this issue?