search

bstroebl / DigitizingTools

A QGIS plugin, that subsumes different tools useful during digitizing sessions
GNU General Public License v2.0
22 stars 9 forks source link

Bring back Amend line #23

Closed PietsHost closed 7 years ago

PietsHost commented 7 years ago

Amend line - removed in Version 0.11.0 (QGIS 2.16+)

Please bring that feature back to DigitizingTools. It's very important for us and we do need that Feature.

Thanks!

bstroebl commented 7 years ago

Hi, glad that you liked it, however it was removed to avoid redundant functions because QGIS' Reshape Features does exactly the same. Could you explain where the Amend line tool is any different from Reshape Features.

PietsHost commented 7 years ago

Reshape Feature? Could you explain, where I do find this function?

bstroebl commented 7 years ago

It's in the Advanced Digitizing Toolbar.

PietsHost commented 7 years ago

Well, I can modify a Line, but I can't expand it.. see here:

http://recordit.co/Shvuh8tY6c

bstroebl commented 7 years ago

Link does not work here (probably a proxy problem), anywys:

  1. enable snapping for the layer in question
  2. aktivate Reshape Features tool
  3. click to either of the line's endpoints (you see it highlighted when within snap distance)
  4. continue clicking for more vertices

see manual

bstroebl commented 7 years ago

Please close this issue if Reshape Features works for you or specify differences to Amend line

PietsHost commented 7 years ago

I guess you don't understand what I want to do.. I just want to extend a line... With the Reshape Tool i can modify it....

mactionreshape <<- Reshape Tool

Here's the Line I want to extend: screenshot_15

my expeted result should be this (adding the black part): screenshot_15

now, using the Reshape Tool: screenshot_16

the result is: screenshot_17

PietsHost commented 7 years ago

and with "add Part" --> screenshot_18

I get this: screenshot_19

bstroebl commented 7 years ago

I do understand what you want to achieve, I know what the Amend line tool used to do. Have you followed my instructions and/or read the manual? Your drawing does suggest that you did not click at the line's endpoint. The manual contains a tip Extend linestring geometries with reshape tool. Add part is for multi-part features which is something completely different.

PietsHost commented 7 years ago

yea I know and I did read the manual. The problem is: If i try to click the line's endpoint, nothing is selected.. Instead it starts drawing

PietsHost commented 7 years ago

screenshot_20 Here I tried to click the line's endpoint with Reshape Tool enabled.. It's just 1 click on the "x" (endpoint) and a second click a few cm away.. doesn't work and the endpoint isn't selected

bstroebl commented 7 years ago

Is snapping enabled for the layer?

Here is my line: line1

mouse cursor is not visible but you can see the endpoint being highlighted as snap point when the mouse is within snap distance line2

click to catch the snappoint and amend the line with further clicks line3

line finished (not saved yet) line4

this is in QGIS 2.18.12 on Linux

PietsHost commented 7 years ago

oh wow.. mal kurz auf Deutsch:

Ich habe die Einstellungen für's "Snapping" aka "Objektfang" nicht gefunden.. Hat so aber tatsächlich funktioniert. Besten Dank!

bstroebl commented 7 years ago

Gut, aber Fangen mußte auch für Amend line in DigitizingTools eingestellt sein, soweit ich mich erinnere, sonst wurde auch kein Endpunkt gefangen.

PietsHost commented 7 years ago

Ne, eben nicht. Für Amend line ging's out-of-the-box ;)

bstroebl commented 7 years ago

Na, aber er muß doch wissen, an welche Linie er ansnappen soll, im Code ist jedenfalls was mit snapping drin. Vielleicht hattest Du das Snapping auch defaultmässig für den aktuellen Layer an? Ist ja auch egal, jetzt geht es jedenfalls.