search

bsudekum / MapTab

Tab Chrome extension for viewing local date, time and location on a map.
62 stars 34 forks source link

Add option to not show time #10

Closed muan closed 8 years ago

muan commented 9 years ago

Hi! Thanks for this, the maps are gorgeous! Every time I refresh I was amazed – "wow where is that what to check it out".

However when I do that, the time is totally in the way! Honestly I want this extension for the beautiful maps and not the time display, so I really want there to be a way to get rid of the time display!

This pull request does it. :sparkles: Here's a demo: http://cl.ly/3v3D2y1q3D3X

However note that this is the first time ever I use React so I might be doing all kinds of things wrong; in that case please do let me know.

Thanks! And awesome job making this! :raised_hands:

bsudekum commented 9 years ago

Hi @muan! I'm not sure how I feel about this addition. Concerns:

  1. the options panel is growing large
  2. if time is optional, should the location text also be optional?

Let me pull it locally and see how it feels.

muan commented 9 years ago
  1. the options panel is growing large

That's true. I also did feel like for something as simple as a toggle it's taking up a lot of real estate.

  1. if time is optional, should the location text also be optional?

I think my reason for time being optional does not apply to the location since it's off to the side and not obstructing. I'd think this should only be a consideration if there's a good reason for it to be optional as well.

But, yeah, see how you feel. ;)