bsuh / node_xslt

a simple XSLT addon for node
zlib License
71 stars 17 forks source link

Issue with wscript during build #5

Closed chorrell closed 12 years ago

chorrell commented 12 years ago

Having an issue getting this to install, failing on the node-waf configure build part:

http://pastie.org/private/efsfgwwnm2v6phxa3f3ca

In wscript. tt looks like obj.cxxflags (line 20 in node_xslt/wscript) wants a list but is getting a string.

Appending .split() to :

obj.cxxflags = subprocess.Popen(["xml2-config", "--cflags"], stdout=subprocess.PIPE).communicate()[0].strip()

So it's:

obj.cxxflags = subprocess.Popen(["xml2-config", "--cflags"], stdout=subprocess.PIPE).communicate()[0].strip().split()

fixes the issue

bsuh commented 12 years ago

Fixed in 1789ebdd27cfff9a599a7e87d7d73e1911a7da91 and published to npm.

Thanks for reporting the issue.