search

bsumlin / PyMieScatt

A collection of forward and inverse Mie solving routines for Python 3, based on Bohren and Huffman's Mie Theory derivations
http://pymiescatt.readthedocs.io/en/latest/
MIT License
101 stars 39 forks source link

Add LICENSE.md so it gets packaged in the source dist #7

Closed hmaarrfk closed 5 years ago

hmaarrfk commented 5 years ago

I noticed there is an other license file in the folder PyMieScat, is that one no longer the license you want to release your code under? If so, can you please remove that file to make it clear.

kmuehlbauer commented 5 years ago

@bsumlin Your fine package is available now via conda-forge channel: https://github.com/conda-forge/pymiescatt-feedstock

For the packaging it would be great to get the licensing correct. If you need any help, please let me know.

bsumlin commented 5 years ago

Thanks for putting this on conda-forge! I’ve updated setup.py in the main repo to reflect the MIT license, and I’ve made a pull request on the conda package to update the license file.

-Ben

From: Kai Mühlbauer notifications@github.com Sent: Tuesday, December 11, 2018 1:56 AM To: bsumlin/PyMieScatt PyMieScatt@noreply.github.com Cc: Sumlin, Ben bsumlin@wustl.edu; Mention mention@noreply.github.com Subject: Re: [bsumlin/PyMieScatt] Add LICENSE.md so it gets packaged in the source dist (#7)

@bsumlinhttps://github.com/bsumlin Your fine package is available now via conda-forge channel: https://github.com/conda-forge/pymiescatt-feedstock

For the packaging it would be great to get the licensing correct. If you need any help, please let me know.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/bsumlin/PyMieScatt/pull/7#issuecomment-446105875, or mute the threadhttps://github.com/notifications/unsubscribe-auth/Ac7Fcz0I2jcoOeG6F-dcADeYQhYZDtOaks5u32UYgaJpZM4ZLRHe.

kmuehlbauer commented 5 years ago

@bsumlin Thanks for addressing the license issue within setup.py.

If you merge this PR, then your LICENCE.md will be added to the tarball when creating a source distribution.

Another thing is what @hmaarrfk mentioned: the license file in the PyMieScatt subfolder. This should be removed to clear the issue.

bsumlin commented 5 years ago

Merged! Hopefully this clears up the licensing.

kmuehlbauer commented 5 years ago

@bsumlin Great! Thanks! The last thing in the license trouble is this file: https://github.com/bsumlin/PyMieScatt/blob/master/PyMieScatt/LICENSE

This file mentions GPL and is irritating. If this is not intended it is best to remove it completely.

bsumlin commented 5 years ago

@kmuehlbauer done!

kmuehlbauer commented 5 years ago

Perfect! Sorry for being kind of a nuisance here.

hmaarrfk commented 5 years ago

Thanks, this is just about being clear about your intentions as the author of this package!

The documentation about the license_file field is super obscure and I can't even find it now. I know that it works though and it is the only reliable way to get the license in the source dist that you publish. Thanks for doing this!