search

bsutton / sounds

Flutter plugin for sound. Audio recorder and player.
GNU Lesser General Public License v3.0
78 stars 25 forks source link

SoundRecorder Documentation wrong #19

Closed zxl777 closed 4 years ago

zxl777 commented 4 years ago

The sample code is handwritten and has not been actually verified. When I actually ran it, I found two spelling errors that caused it to fail to compile.

In addition, this example cannot actually stop recording. I have to delete recorder.onStopped to recorder.stop().

Can you try to improve the source code of this document and example, thank you.

mdkess commented 4 years ago

https://github.com/bsutton/sounds/wiki/SoundRecorder#permissions also has references to .start() instead of .record() - I suspect this is because of the fork.

bsutton commented 4 years ago

Thanks for the feed back. I've now checked that all the snippets on the recording page compile.

The api was a bit of a moving target when the doco was originally written.

Any other reviews of the doco would be appreciated.