bsvars / bsvarSIGNs

Bayesian SVARs with Sign, Zero, and Narrative Restrictions
http://bsvars.org/bsvarSIGNs/
Other
9 stars 2 forks source link

# Rotation matrices #51

Open giannilmbd opened 1 week ago

giannilmbd commented 1 week ago

It is not clear to me how the rotation matrices (Qs) are drawn and stored. In the documentation (pdf) I cannot find the referred to in the estimation command, yet the estimation algorithm suggests that Q are drawn until eg the sign restriction is satisfied. Also it seems to me that Q is NxNxS, so as many Qs as posterior draws.

Should we not draw several Qs for each posterior draw and retain the whole set that satisfied the identifying restrictions? Or have I misunderstood the documentation?

Thanks Gianni

donotdespair commented 5 days ago

Hi @giannilmbd

Thanks for reaching out! Yes, indeed, there's a lot that is happenning here and we need to be clearer on this in the documentation. The changes are coming up!

To address your questions....

  1. In the estimation output we provide the draws for parameters $A$, $\Sigma$ and $Q$ sampled from Normal-Wishart-Haar representation. They are used to compute the parameters of the Structural model $A$ and $B$, where the autoregressive matrix $A$ is the same, that we also provide in th estimation output.
  2. Yes, there's a $Q$ sampled for each $A$ and $\Sigma$ and provided in the output. But indeed in th default setup the max_tries argument of the specify_bsvarSIGN$new() function is set to Inf, which means that $Q$ is sampled as long as the right one is found.
  3. To set the algorithms such that only one $Q$ is sampled for each draw of $A$ and $\Sigma$, and subsequently all of these are accepted or rejected you need to set max_tries = 1

Does this help?

Please, let us know @giannilmbd

Cheers, T

donotdespair commented 5 days ago

Hey @adamwang15

Could you please:

Thanks!

Cheers, T @donotdespair

adamwang15 commented 5 days ago

Hi @donotdespair and @giannilmbd

Yes, in the current default setting, max_tries is set to Inf indicating that given one draw of $(A,\Sigma)$ the algorithm will keep sampling $Q$ until it finds one that satisfies all the restrictions. This is purely to speed up the algorithm (more effective samples), changing the argument in specify_bsvarSIGN$new() to max_tries = 1 gives you the original algorithm in Antolín-Díaz & Rubio-Ramírez (2018) and Arias, Rubio-Ramírez & Waggoner (2018).

No problem, I will update the default setting and the vignette in the next version!

Cheers, Adam

giannilmbd commented 4 days ago

Dear all,

I'm not sure I fully understand (my personal max iter might well be inf too).

I think that for each posterior draw, there might be L acceptable Qs.

For example at the posterior mode, there are possibly several Qs (eg L of these) such that the restrictions are satisfied.

So, while there should be S reduced form matrices A, there should be S \times L Q matrices. Right?

donotdespair commented 3 days ago

Ah, I see, @giannilmbd!

This package does not allow more draws of $Q$ than those of other parameters, like $A$ and $\Sigma$. It's always that S of them are returned. Now the package allows two estimation procedures:

  1. For each draw of $A$ and $\Sigma$ try just one $Q$, and accept or reject all the parameters at once. This is recommended by the original authors bc in such a case $Q$ is drawn from a distribution conditioned on the restrictions only.
  2. For each draw of $A$ and $\Sigma$ sample different $Q$s as long as you find one that satisfies the sign restrictions. This one is faster but Arias, Rubio-Ramírez & Waggoner (2018), criticise this approach for sampling $Q$ from a different distribution, a full conditional posterior that depends on $A$ and $\Sigma$ as well. I am not sure if Rubio-Ramírez mentions this in this particular paper, but he does so in one of them, and I think it was this one.

We do not allow many draws of $Q$ to be returned for a single draw of $A$ and $\Sigma$. Would such an option be any useful for you? Why would it be? Let us know.

Greetings,

T

giannilmbd commented 3 days ago

Hi, Thanks for the clarification. I suspect though that I might be misunderstanding a few things at this point. Or maybe we are talking past each other.

I thought that sign restrictions lead to set identification. So assuming for the sake of argument that the reduced parameters are known (eg the uncertainty is negligible) we would most likely still have several Qs that satisfy the constraints.

In that case S=1 but L (the number of Qs) >1

Proceeding with this thought experiment, for each further S (eg S=2) you would have two sets of Qs, eg the first of length L1 the second of length L2 etc.

Following you procedure 1, you accept only one Q for posterior draws. This in principle reduces considerably the uncertainty.

Am I wrong?

Tomasz Woźniak @.***> schrieb am Di. 12. Nov. 2024 um 06:31:

Ah, I see, @giannilmbd https://github.com/giannilmbd!

This package does not allow more draws of $Q$ than those of other parameters, like $A$ and $\Sigma$. It's always that S of them are returned. Now the package allows two estimation procedures:

  1. For each draw of $A$ and $\Sigma$ try just one $Q$, and accept or reject all the parameters at once. This is recommended by the original authors bc in such a case $Q$ is drawn from a distribution conditioned on the restrictions only.
  2. For each draw of $A$ and $\Sigma$ sample different $Q$s as long as you find one that satisfies the sign restrictions. This one is faster but Arias, Rubio-Ramírez & Waggoner (2018), criticise this approach for sampling $Q$ from a different distribution, a full conditional posterior that depends on $A$ and $\Sigma$ as well. I am not sure if Rubio-Ramírez mentions this in this particular paper, but he does so in one of them, and I think it was this one.

We do not allow many draws of $Q$ to be returned for a single draw of $A$ and $\Sigma$. Would such an option be any useful for you? Why would it be? Let us know.

Greetings,

T

— Reply to this email directly, view it on GitHub https://github.com/bsvars/bsvarSIGNs/issues/51#issuecomment-2469644660, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHLXB3YZFADXNQJ5YRGYV2T2AGHBRAVCNFSM6AAAAABRJOR25GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRZGY2DINRWGA . You are receiving this because you were mentioned.Message ID: @.***>

donotdespair commented 3 days ago

Hey @giannilmbd

The approach you described, with many $Q$s per an estimate of $A$ and $\Sigma$ is often used in frequentist approach, but using it has some consequences to the implied distribution of the IRFs Baumeister & Hamilton (2015).

Our package implements Bayesian approach that facilitates the assessment of uncertainty. You obtain S draws of parameters $Q^{(s)}, A^{(s)}, \Sigma^{(s)}$ or alternatively and equivalently of $A^{(s)}, B^{(s)}$, for S = 1,...,S. Each draw of $Q^{(s)}$ is different. So, you always have as many different draws of $Q$ as those of $A$ and $\Sigma$.

My answers above just point out to two ways of obtaining $Q$ draws depending on the value of argument max_tries. We follow closely the papers mentioned in the package description just to assure such compatibility.

Greetings, T

giannilmbd commented 3 days ago

Dear Tomasz, Nice subtle comment about me not being able to understand the literature. I thought we were simply trying to let me understand what your code does. That's unfortunate and maybe suggests I should give up on this conversation. The excerpt below is from Kilian and Luetkepohl. [image: image.png] [image: image.png]

On Tue, Nov 12, 2024 at 7:35 AM Tomasz Woźniak @.***> wrote:

Hey @giannilmbd https://github.com/giannilmbd

Not quite! The approach you described, with many $Q$s per estimate of $A$ and $\Sigma$ is often used in frequentist approach, but severly criticised by Baumeister & Hamilton (2015) https://doi.org/10.3982/ECTA12356 and others. It was never a recommended approach. Note that in this case, we cannot talk about any assessment of estimation uncertainty bc all of the IRFs are based on orthogonal projections and entertain the same value of likelihood.

Our package implements Bayesian approach that facilitates the assessment of uncertainty. You obtain S draws of parameters $(Q^{(s)}, A^{(s)}, \Sigma^{(s)}){s=1}^S$, or alternatively and equivalently of $(A^{(s)}, B^{(s)}){s=1}^S$. Each draw of $Q^{(s)}$ is different. So, you always have as many different draws of $Q$ as those of $A$ and $\Sigma$. My answers above just point out to two ways of obtaining $Q$ draws depending on the value of argument max_tries .

We follow closely the papers mentioned in the package description and they should be the best reference. I realise they are not easy readings, but that's what we're doing in the package.

Greetings, T

— Reply to this email directly, view it on GitHub https://github.com/bsvars/bsvarSIGNs/issues/51#issuecomment-2469714847, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHLXB36YXPC3SX3DA4OPYFD2AGOR7AVCNFSM6AAAAABRJOR25GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRZG4YTIOBUG4 . You are receiving this because you were mentioned.Message ID: @.***>

donotdespair commented 3 days ago

Hey @giannilmbd

No, it's not that! Apologies if it sounded like that! This issues are communicated in individual sentences from several papers. And we had to read each of them several times to find the connections. But we had to do this to make certain that we knew what we were doing and that our package works and does what we want it to. And this took us quite some time. But we never worked with frequenmtists sign-identified models and at least we did not have to figure out the differences between these approaches and Bayesian. And it seems that practices are quite different.

Please, take my previous post just as a clarification of what we do in the package, and I'll reedit it to get rid of any insinuation.

Could you please upload passages from KL again? Somehow, I can't see them. Thanks!

Again, sincere apologies for the tone. No such insinuations were intended.

Greetings, T

giannilmbd commented 2 days ago

Dea Tomasz, By reading the recent paper UNIFORM PRIORS FOR IMPULSE RESPONSES1 Jonas E. Ariasa, Juan F. Rubio-Ramirez and Daniel F. Waggoner I finally believe I understand. I repeat this aloud not to explain it to you (you know it already) but sor my sanity.

Since Q is independent of the data, there is no need to draw conditionally on the posterior. Provided one takes a sufficiently large number of draws of parameters and Qs, the likelihood of having several Qs for each parameter constellation is high.

The adventage of the simultaneous draw is that you can discard the structural parameters that won’t be matched by any valid Qs.

A sequential method is not wrong (same resulting distribution) but inefficient.

Thanks again for your patience and time.

All the best

Gianni

Tomasz Woźniak @.***> schrieb am Mi. 13. Nov. 2024 um 01:23:

Hey @giannilmbd https://github.com/giannilmbd

No, it's not that! Apologies if it sounded like that! This issues are communicated in a individual sentences from several papers. And we had to read each of them several times to find the connections. But we had to do this to make certain that we knew what we were doing and that our package works and does what we want it to. And this took us quite some time. But we never worked with frequenmtists sign-identified models and at least we did not have to figure out the differences between these approaches and Bayesian. And it seems that practices are quite different.

Please, take my previous post just as a clarification of what we do in the package, and I'll reedit it to get rid of any insinuation.

Could you please upload passages from KL again? Somehow, I can't see them. Thanks!

Again, sincere apologies for the tone. No such insinuations were intended.

Greetings, T

— Reply to this email directly, view it on GitHub https://github.com/bsvars/bsvarSIGNs/issues/51#issuecomment-2472005350, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHLXB3YJ3SGGYKM6EUYWIRD2AKLZFAVCNFSM6AAAAABRJOR25GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINZSGAYDKMZVGA . You are receiving this because you were mentioned.Message ID: @.***>

donotdespair commented 2 days ago

That's right! I am only about to read this one!

I will just add that stats and maths of the two cases of having multiple realisation of $Q$ for a single draw of $A^{(s)}$ and $\Sigma^{(s)}$ (and many draws) is very different from having them for a single value of the maximum likelihood estimator $\hat{A}$ and $\hat{\Sigma}$.

Thank you so much for your diligence! We learn from you a lot!

Greetings, T