search

bswinnerton / launchbar-github

A LaunchBar action for GitHub
http://launchbar-github.com
MIT License
70 stars 7 forks source link

Add support for matching repos with dots in their name #84

Closed jasonrudolph closed 6 years ago

jasonrudolph commented 6 years ago

Before

before

After

after

I hope this helps. If there's anything you'd like to see changed in order to get this suitable to be merged, just let me know. :bow:

bswinnerton commented 6 years ago

Thank you for the pull request, @jasonrudolph!

There were two odd things that I noticed with this pull request, neither of which were a result of your changes.

  1. I noticed that tests weren't being run in Circle CI on pull requests which originate from a fork, which I resolved by following these instructions.
  2. When checking out this pull request locally to test, I noticed that when running script/build I was getting a different output than what you had generated and submitted. At first, I thought this was perhaps because you had forgotten to run script/build, which prompted me to open https://github.com/bswinnerton/launchbar-github/issues/85. But I ultimately realized that you were using a newer version of Babel than I was. So I updated the bundle.min.js file to use the latest version of Babel, as well as added a test to resolve #85 in https://github.com/bswinnerton/launchbar-github/pull/86.

I'm writing both of these things mostly for the sake of posterity, but wanted to leave it here in case you were curious why I had merged master into your branch before merging.

Thank you for the submission! I especially appreciated the before and after gifs to showcase the changes. I'll cut a new release later today.