search

bswinnerton / launchbar-github

A LaunchBar action for GitHub
http://launchbar-github.com
MIT License
70 stars 7 forks source link

Add support to go directly to URL before API call #88

Closed bswinnerton closed 6 years ago

bswinnerton commented 6 years ago

As reported in #87, if you type the repository that you would like to go to without waiting for the GitHub API to respond, ⌘ + Enter does not work.

This commit adds support to use ⌘ + Enter to go directly to the repository before triggering an API call to fetch all of the account's repositories.

This is a little easier to review using GitHub's ?w=1 feature

Resolves #87.

bswinnerton commented 6 years ago

👋 @jasonrudolph, this should resolve your comment in https://github.com/bswinnerton/launchbar-github/issues/8#issuecomment-340189604 (and by relation, #87).

Unfortunately there's a catch 😕. The order of repositories that comes back from the GitHub API doesn't take into account the exact search term. So if you hit ⌘ + Enter immediately after the repositories are shown in LaunchBar, you'll need to navigate down to your entry before hitting ⌘ + Enter. I've opened https://github.com/bswinnerton/launchbar-github/issues/89 to explore ways of reordering the list of repositories so this doesn't happen.

bswinnerton commented 6 years ago

Unfortunately there's a catch 😕.

I've resolved said catch in https://github.com/bswinnerton/launchbar-github/pull/90 😄.