search

bsyk / cf-letsencrypt

Let's Encrypt wrapper for Cloud-Foundry
MIT License
27 stars 22 forks source link

Request to merge with updates for Diego compatibility #9

Closed gokulk04 closed 7 years ago

gokulk04 commented 7 years ago
  1. Substituted "cf files" command wth "cf ssh" command to ensure Diego compatibility while requesting for certificates
  2. Added a wait() function for each of the get_cert subprocesses to ensure the "cf stop" command does not stop the app prematurely before all certificates are properly retrieved
lmsurpre commented 7 years ago

@gokulk04 thanks for submitting the pull request. however, I think we'd like to treat cf-letsencrypt as an 'upstream' version of bluemix-letsencrypt (with no bluemix-specific functionality)

Please open a new pull request with only the changes necessary to make cf-letsencrypt work on diego. I think its just a matter of printing out the 'cf ssh' commands instead of the 'cf files' ones since diego doesn't work with 'cf files'.