bt-rb / bridgetown-plausible

Plausible Analytics Bridgetown Plugin
MIT License
11 stars 0 forks source link

Make server configurable #11

Closed whysthatso closed 2 years ago

whysthatso commented 2 years ago

What kind of change does this PR introduce? (check at least one)

Does this PR introduce a breaking change? (check one)

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

Other information: i've bumped up the bridgetown version to 1.1.0. i thin that led to a changed directory structure which in turn required test adjustments. i've not dug too much into that, so maybe something else was the reason:

whysthatso commented 2 years ago

hm, i hope i did it alright with the mix of committing suggestions and resolving conversations. i'm not very versed in the whole github pr workflow, but i really appreciate it. also including the proper contribution steps into the project right from the start was very wise, i think.

i think there is no controversy here, just do as you see fit for the rest of the things. it's a small feature detail after all :)

btw thanks for all the work. also the podcast :D

whysthatso commented 2 years ago

ok, so i just took some action here, i hope it's all in your favor as well.

andrewmcodes commented 2 years ago

@whysthatso thanks for the contribution! I just released v1.1.0 with these changes.

whysthatso commented 2 years ago

so cool 🤗 thanks.