bt-sync / sync-docker

Resilio Sync docker image
https://www.resilio.com
178 stars 59 forks source link

adds ability to start rslsync with specific GID and UID #13

Closed dionysiusmarquis closed 6 years ago

dionysiusmarquis commented 7 years ago

fixes #12

This will create a resilio group and user with the provided env variables "UID" and "GID". To be able to change the GID and UID after first run I implemented a brute force method wich will destroy the current resilio group and user and creates a new one on every start. Maybe there is a more elegant way…, but its a start and adds the ability to run resilio via Docker as non root user

EugenMayer commented 7 years ago

Any reason this is ignored? this is more as mission critical, especially e.g. when you run this on a synology NAS and similar.

pascalwhoop commented 6 years ago

I believe inspiration could be taken from https://github.com/janeczku/docker-dropbox/blob/master/run

Also the Readme should be updated accordingly. @dionysiusmarquis you want to look into this again or do you think the package maintainers don't react anyways? In which case forking and republishing on your own on docker hub might be a smart move. Also a nice package to call "yours"

dionysiusmarquis commented 6 years ago

I actually have an auto building docker on docker hub: https://hub.docker.com/r/dionysiusmarquis/resilio-sync/ I'm trying to keep it up to date but no guarantee that this is a best practice and production ready approach. I'm using it since then and it's working fine for me. But as said: no guarantee

EugenMayer commented 6 years ago

doing the same for quiet a while, since that one with not moving https://github.com/EugenMayer/docker-image-btsync @dionysiusmarquis .. i forked from you back in the days to be able to have more up2date builds. Lets see if i can go back.

pascalwhoop commented 6 years ago

Could you two create an orga and place it there? Then other contributors can come and go but no one is bound to keep it up to date/

artempronevskiy commented 6 years ago

@dionysiusmarquis you don't need to use this solution, please use --user parameter instead. Docs.

EugenMayer commented 6 years ago

@artempronevskiy unbelievable statement while being so massively clueless. Move along.