search

btactic-oo / unlimited-onlyoffice-package-builder

Unlimited OnlyOffice Package Builder
GNU General Public License v3.0
24 stars 9 forks source link

Feedback on README-BUILD-NEWER-VERSIONS.md (v0.0.2) #4

Open adriangibanelbtactic opened 1 week ago

adriangibanelbtactic commented 1 week ago

README-BUILD-NEWER-VERSIONS.md v0.0.2 is available to anyone.

Now you can easily recreate the btactic-oo builds and report back which versions need further changes (or not).

Feedback is welcome so that we polish the document.

Please notice that if you try to build 8.1.3.3 version thanks to Github Actions you should remove onlyoffice-unlimited-build-debian-11/8.1.3.3 and builds-debian-11/8.1.3.3 tags from your unlimited-onlyoffice-package-builder repo just after you fork it from ours or, in any case, just before the Github Actions's Push to build section.

Nocodemon commented 1 week ago

Very good how-to, I got an error at the first cherry pick . https://github.com/btactic-oo/unlimited-onlyoffice-package-builder/blob/v0.0.2/README-BUILD-NEWER-VERSIONS.md#apply-no-limits-to-our-repos-desktopm and had to do git stash. Othewise everything was straightforward. I didn't check this page first though and wonder if I can remove the tags later in the process like just before building or if I need to redo the guide.

Nocodemon commented 1 week ago

Also, since we know the build can and will go wrong,maybe we should explain from where you should start from scratch. Is it enough to just delete the old docker images and start the build script again or do I need to start from another point in the how-to

Nocodemon commented 1 week ago

Is it also possible to stop the build before it makes the deb packages for those that don't need a .deb file. Or is better to just unpack the deb file and use that?

adriangibanelbtactic commented 1 week ago

Very good how-to, I got an error at the first cherry pick . https://github.com/btactic-oo/unlimited-onlyoffice-package-builder/blob/v0.0.2/README-BUILD-NEWER-VERSIONS.md#apply-no-limits-to-our-repos-desktopm and had to do git stash.

I would like to reproduce your error to see if it's expected or not. What specific version were you aiming for?

adriangibanelbtactic commented 1 week ago

I didn't check this page first though and wonder if I can remove the tags later in the process like just before building or if I need to redo the guide.

You need to remove both remove both onlyoffice-unlimited-build-debian-11/8.1.3.3 and builds-debian-11/8.1.3.3 tags from your unlimited-onlyoffice-package-builder repo if you plan on building that version using the Github Actions.

In any case you have remove them just before the Github Actions's Push to build section. Otherwise the push described failed there (builds-debian-11/8.1.3.3) and, later on, you won't be able to create an specific release because of the tag (onlyoffice-unlimited-build-debian-11/8.1.3.3) associated to the release already being there.

I will update the original warning so that it's easier to understand.

adriangibanelbtactic commented 1 week ago

Also, since we know the build can and will go wrong,maybe we should explain from where you should start from scratch. Is it enough to just delete the old docker images and start the build script again or do I need to start from another point in the how-to

I think you should be fine by just removing or renaming the ~/build-oo directory and then resume from Build (BUILDM)'s Build everything section.

In any case if there's a more deep problem you might want to delete the docker container so that the docker build actually gets built from scratch and not rebuild from cache.

TODO: Add an If something goes wrong subsection inside the Build (BUILDM) section.

adriangibanelbtactic commented 1 week ago

Is it also possible to stop the build before it makes the deb packages for those that don't need a .deb file. Or is better to just unpack the deb file and use that?

If you want to build a Docker image or an RPM you'd better start a new issue and we can discuss it there.

But in a nutshell what you want is to add the --binaries-only switch.

The original:

./onlyoffice-package-builder.sh --product-version=@@VERSION-X.Y.Z@@ --build-number=@@VERSION-T@@ --unlimited-organization=@@ACMEOO@@ --tag-suffix=-@@ACME@@ --debian-package-suffix=-@@ACME@@

gets converted onto:

./onlyoffice-package-builder.sh --product-version=@@VERSION-X.Y.Z@@ --build-number=@@VERSION-T@@ --unlimited-organization=@@ACMEOO@@ --tag-suffix=-@@ACME@@ --debian-package-suffix=-@@ACME@@ --binaries-only

.

Nocodemon commented 1 week ago

Very good how-to, I got an error at the first cherry pick . https://github.com/btactic-oo/unlimited-onlyoffice-package-builder/blob/v0.0.2/README-BUILD-NEWER-VERSIONS.md#apply-no-limits-to-our-repos-desktopm and had to do git stash.

I would like to reproduce your error to see if it's expected or not. What specific version were you aiming for?

I was trying 8.1.3.3. I have successfully built according to the how-to I had to restart once because of a error cloning some repo. Since you don't delete the out folder all binaries are in there but it's nice to be able to skip the deb building part so appreciate the --binaries-only. Now to see if I can get it to run on my server :)

adriangibanelbtactic commented 1 week ago

Very good how-to, I got an error at the first cherry pick . https://github.com/btactic-oo/unlimited-onlyoffice-package-builder/blob/v0.0.2/README-BUILD-NEWER-VERSIONS.md#apply-no-limits-to-our-repos-desktopm and had to do git stash.

I would like to reproduce your error to see if it's expected or not. What specific version were you aiming for?

I was trying 8.1.3.3. I have successfully built according to the how-to I had to restart once because of a error cloning some repo.

Nice, I don't need to fix the how-to regarding the first cherry-pick then. Or do I?

Nocodemon commented 1 week ago

It worked!!! Thank you so much, you going to gartner symposium in november @adriangibanelbtactic?

Very good how-to, I got an error at the first cherry pick . https://github.com/btactic-oo/unlimited-onlyoffice-package-builder/blob/v0.0.2/README-BUILD-NEWER-VERSIONS.md#apply-no-limits-to-our-repos-desktopm and had to do git stash.

I would like to reproduce your error to see if it's expected or not. What specific version were you aiming for?

I was trying 8.1.3.3. I have successfully built according to the how-to I had to restart once because of a error cloning some repo.

Nice, I don't need to fix the how-to regarding the first cherry-pick then. Or do I?

You could add a if you get a error that you can't cherry pick then run git stash?

adriangibanelbtactic commented 1 week ago

It worked!!! Thank you so much,

:)

adriangibanelbtactic commented 1 week ago

you going to gartner symposium in november @adriangibanelbtactic?

No, I'm not.

adriangibanelbtactic commented 1 week ago

Very good how-to, I got an error at the first cherry pick . https://github.com/btactic-oo/unlimited-onlyoffice-package-builder/blob/v0.0.2/README-BUILD-NEWER-VERSIONS.md#apply-no-limits-to-our-repos-desktopm and had to do git stash.

I would like to reproduce your error to see if it's expected or not. What specific version were you aiming for?

I was trying 8.1.3.3. I have successfully built according to the how-to I had to restart once because of a error cloning some repo.

Nice, I don't need to fix the how-to regarding the first cherry-pick then. Or do I?

You could add a if you get a error that you can't cherry pick then run git stash?

  1. Usually when the cherry-pick fails you have a message that tells you to use git cherry-pick --abort (or something similar) to revert everything to the original status. I think that's much better than ask someone to git stash.

  2. I still don't know what happened to you because you did not provide any copy-and-paste of the error. I don't know what was the exact cherry-pick error because they can be many of them.

  3. Also... Would it happen to you again if you followed the how-to instructions again?

  4. Did you finally apply the first cherry-pick or did you manage to build everything despite not applying the first cherry-pick?

Nocodemon commented 1 week ago

After I Stashed I could cherry-pick. I'll try and do everything from scratch and post the exact error if it occurs again.

you going to gartner symposium in november @adriangibanelbtactic?

No, I'm not.

Darnit, I thought I could get you a thank you gift/Beer 😁