Outdated code in C++ generator breaks the compilation

btc-ag / service-idl

Xtext-based Service IDL (Interface Definition Language) and Code Generators for Protobuf, C++, Java and .NET

Eclipse Public License 2.0

8 stars 8 forks source link

Outdated code in C++ generator breaks the compilation #116

Closed huttenlocher closed 6 years ago

huttenlocher commented 6 years ago

Upon migration to recent CAB Commons versions there are some now invalid parts in C++ generator code, which hinder generated code from being compiled. Most of them are in the ODB project "ExternalDBImpl", but also in case of custom exception types in the IDL; e.g. there is an invalid override: virtual BTC::Commons::Core::Exception *IntClone() const; I have already fixed these problems locally while working on the .NET failable handler support and will provide a pull request for this issue.

sigiesec commented 6 years ago

This probably applies when using cpp.servicecomm=0.12 only, right?

huttenlocher commented 6 years ago

Good point. Probably yes, I should take care to retain compatibility.

sigiesec commented 6 years ago

Yes ;) The integration test runner can run test cases for all target versions.