search

btc-ag / service-idl

Xtext-based Service IDL (Interface Definition Language) and Code Generators for Protobuf, C++, Java and .NET
Eclipse Public License 2.0
8 stars 8 forks source link

Refactor cpp generator further #12

Closed sigiesec closed 6 years ago

sigiesec commented 6 years ago

This change is Reviewable

codecov[bot] commented 6 years ago

Codecov Report

Merging #12 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #12   +/-   ##
=========================================
  Coverage     88.32%   88.32%           
  Complexity       43       43           
=========================================
  Files            12       12           
  Lines           137      137           
  Branches          2        2           
=========================================
  Hits            121      121           
  Misses           16       16

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 95b0e73...38a487b. Read the comment docs.

schregger commented 6 years ago

Reviewed 10 of 13 files at r6, 3 of 3 files at r7. Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable