OP_20 transfer_from doesn't allow approved contracts - Githubissues

btc-vision / btc-runtime

Assemblyscript btc runtime

MIT License

4 stars 2 forks source link

OP_20 transfer_from doesn't allow approved contracts #31

Closed liquitious closed 3 weeks ago

liquitious commented 3 weeks ago

This check here prevents a contract from doing an (approved) transferFrom https://github.com/btc-vision/btc-runtime/blob/d131d381b7aab78a2e77091e0acd3918c9686a88/runtime/contracts/DeployableOP_20.ts#L359

That makes the allowance useless as this is only called by the token owner https://github.com/btc-vision/btc-runtime/blob/d131d381b7aab78a2e77091e0acd3918c9686a88/runtime/contracts/DeployableOP_20.ts#L365

ie this flow doesn't work:

alice approves a 1 WBTC allowance to TestContract
TestContract executes a WBTC safeTransferFrom alice
this is impossible and fails

BlobMaster41 commented 3 weeks ago

Will review! Thanks!

BlobMaster41 commented 3 weeks ago

This issue got resolved.