Valid taproot signature may not must has length of 64 - Githubissues

btclib-org / btclib

btclib: a python3 library for 'bitcoin cryptography'

https://btclib.org

MIT License

97 stars 42 forks source link

Valid taproot signature may not must has length of 64 #122

Open timqi opened 6 months ago

timqi commented 6 months ago

Describe the bug It seems not right to check signature of taproot is valid by assert length of it equals 64: https://github.com/btclib-org/btclib/blob/da0cfc146545c1ec220901094c98e32690f255af/btclib/psbt/psbt_utils.py#L307

To Reproduce There is an example on how to make a valid taproot signature which length is not 64: https://github.com/bitcoinjs/bitcoinjs-lib/issues/1934

Environment (please complete the following information):

OS: ubuntu
Python version: 3.10.13
btclib version: da0cfc146545c1ec220901094c98e32690f255af master 2023.12.12

timqi commented 6 months ago

Will it support sign psbt from library?